Re: Should we hook up sashiko.dev?

[Brian Foster <bfoster@redhat.com>]

On Tue, Apr 21, 2026 at 06:47:01PM -0500, Eric Sandeen wrote:
> On 4/15/26 11:49 AM, Eric Sandeen wrote:
> > Hi all - 
> > 
> > "Sashiko is an agentic Linux kernel code review system. It monitors public mailing lists to thoroughly evaluate proposed Linux kernel changes. The system acts like a team of specialized reviewers covering domains from high-level architecture verification and security audits to low-level resource management and concurrency analysis."
> > 
> > This is something built by Chris Mason and others, with Google providing the LLM and tokens.
> > 
> > The website sashiko.dev shows these review results for mailing lists it is subscribed to, so you can browse around and see how it works. I've heard reasonably positive feedback from some who've used it already.
> > 
> > We could send a PR to request adding linux-xfs, and I think we should try it.
> 
> Ok, we're connected: https://sashiko.dev/#/?list=org.kernel.vger.linux-xfs
> 
> for now it is not sending any emails; it's web-only. Depending on the
> usefulness and accuracy of the reviews, we could consider more than web-only.
> 
> I'd like to set up some xfs-specific review prompts, but apparently we need
> to be somewhat sparse on that due to token usage for a large set of prompts.
> 
> LMK what you think of the review quality!
> 

I just took a quick look at this one and it seems like it's accurate:

https://sashiko.dev/#/patchset/20260420061630.62077-1-changfengnan%40bytedance.com

The flaw isn't actually with the patch, but rather the surrounding code
it touches. It also feels a little weird to me to have a tool that tries
to communicate like a person, but maybe that's just something to get
used to I guess. ;)

Fengnan,

Any chance you want to try to fix that up in your patch, since it's
outstanding and you've created the helper to facilitate it? ;) If not
nbd we can fix it up separately. I don't think it's a pressing issue.

Brian