From: Zorro Lang <zlang@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: djwong@kernel.org, linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/216: pass -t xfs to _mount
Date: Fri, 8 May 2026 02:45:45 +0800 [thread overview]
Message-ID: <afzdcdQ-t8gzlRyY@zlang-mailbox> (raw)
In-Reply-To: <20260507050950.1300316-1-hch@lst.de>
On Thu, May 07, 2026 at 07:09:49AM +0200, Christoph Hellwig wrote:
> Without this, mount probes different file system type, which ended up
> exposing kernel bugs in blocksize > PAGE_SIZE bugs in tons of
> legacy file systems. Bypass that by forcing XFS and making the
> mount a little more efficient.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
This change makes sense to me, thanks for fixing one more lbs testing
failure.
Reviewed-by: Zorro Lang <zlang@kernel.org>
> tests/xfs/216 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/216 b/tests/xfs/216
> index 091c11d08642..2096dd9b53d9 100755
> --- a/tests/xfs/216
> +++ b/tests/xfs/216
> @@ -57,7 +57,7 @@ _do_mkfs()
> echo -n "fssize=${i}g "
> $MKFS_XFS_PROG -f -b size=4096 -l version=2 \
> -d size=${i}g $loop_mkfs_opts $loop_dev |grep log
> - _mount $loop_dev $LOOP_MNT
> + _mount -t xfs $loop_dev $LOOP_MNT
> echo "test write" > $LOOP_MNT/test
> _unmount $LOOP_MNT > /dev/null 2>&1
> done
> --
> 2.53.0
>
prev parent reply other threads:[~2026-05-07 18:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 5:09 [PATCH] xfs/216: pass -t xfs to _mount Christoph Hellwig
2026-05-07 9:20 ` Andrey Albershteyn
2026-05-07 18:45 ` Zorro Lang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afzdcdQ-t8gzlRyY@zlang-mailbox \
--to=zlang@kernel.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox