[PATCH] xfs/216: pass -t xfs to _mount

[PATCH] xfs/216: pass -t xfs to _mount

[Christoph Hellwig]

Without this, mount probes different file system type, which ended up
exposing kernel bugs in blocksize > PAGE_SIZE bugs in tons of
legacy file systems.  Bypass that by forcing XFS and making the
mount a little more efficient.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 tests/xfs/216 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/216 b/tests/xfs/216
index 091c11d08642..2096dd9b53d9 100755
--- a/tests/xfs/216
+++ b/tests/xfs/216
@@ -57,7 +57,7 @@ _do_mkfs()
 		echo -n "fssize=${i}g "
 		$MKFS_XFS_PROG -f -b size=4096 -l version=2 \
 			-d size=${i}g $loop_mkfs_opts $loop_dev |grep log
-		_mount $loop_dev $LOOP_MNT
+		_mount -t xfs $loop_dev $LOOP_MNT
 		echo "test write" > $LOOP_MNT/test
 		_unmount $LOOP_MNT > /dev/null 2>&1
 	done
-- 
2.53.0

Re: [PATCH] xfs/216: pass -t xfs to _mount

[Andrey Albershteyn]

On 2026-05-07 07:09:49, Christoph Hellwig wrote:
> Without this, mount probes different file system type, which ended up
> exposing kernel bugs in blocksize > PAGE_SIZE bugs in tons of
> legacy file systems.  Bypass that by forcing XFS and making the
> mount a little more efficient.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good to me
Reviewed-by: Andrey Albershteyn <aalbersh@kernel.org>

-- 
- Andrey

Re: [PATCH] xfs/216: pass -t xfs to _mount

[Zorro Lang]

On Thu, May 07, 2026 at 07:09:49AM +0200, Christoph Hellwig wrote:
> Without this, mount probes different file system type, which ended up
> exposing kernel bugs in blocksize > PAGE_SIZE bugs in tons of
> legacy file systems.  Bypass that by forcing XFS and making the
> mount a little more efficient.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---

This change makes sense to me, thanks for fixing one more lbs testing
failure.

Reviewed-by: Zorro Lang <zlang@kernel.org>

>  tests/xfs/216 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/216 b/tests/xfs/216
> index 091c11d08642..2096dd9b53d9 100755
> --- a/tests/xfs/216
> +++ b/tests/xfs/216
> @@ -57,7 +57,7 @@ _do_mkfs()
>  		echo -n "fssize=${i}g "
>  		$MKFS_XFS_PROG -f -b size=4096 -l version=2 \
>  			-d size=${i}g $loop_mkfs_opts $loop_dev |grep log
> -		_mount $loop_dev $LOOP_MNT
> +		_mount -t xfs $loop_dev $LOOP_MNT
>  		echo "test write" > $LOOP_MNT/test
>  		_unmount $LOOP_MNT > /dev/null 2>&1
>  	done
> -- 
> 2.53.0
>