Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Carlos Maiolino <cem@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/5] xfs: mark struct xfs_imap as __packed
Date: Mon, 8 Jun 2026 13:53:10 +0200	[thread overview]
Message-ID: <aiatHy6BS4LIXsU-@nidhogg.toxiclabs.cc> (raw)
In-Reply-To: <20260601124410.3508980-6-hch@lst.de>

On Mon, Jun 01, 2026 at 02:43:51PM +0200, Christoph Hellwig wrote:
> This returns 2 bytes of padding at the to struct xfs_inode into which
> this structure is embedded.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

> ---
>  fs/xfs/libxfs/xfs_inode_buf.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_inode_buf.h b/fs/xfs/libxfs/xfs_inode_buf.h
> index 57192adc7744..f3624532b023 100644
> --- a/fs/xfs/libxfs/xfs_inode_buf.h
> +++ b/fs/xfs/libxfs/xfs_inode_buf.h
> @@ -16,7 +16,7 @@ struct xfs_dinode;
>  struct xfs_imap {
>  	xfs_agblock_t	im_agbno;	/* starting agbno of inode cluster */
>  	unsigned short	im_boffset;	/* offset in inode cluster in bytes */
> -};
> +} __packed;
>  
>  int	xfs_read_icluster(struct xfs_perag *pag, struct xfs_trans *tp,
>  		xfs_agblock_t agbno, struct xfs_buf **bpp);
> -- 
> 2.53.0
> 

  parent reply	other threads:[~2026-06-08 11:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 12:43 shrink struct xfs_imap Christoph Hellwig
2026-06-01 12:43 ` [PATCH 1/5] xfs: cleanup xfs_imap Christoph Hellwig
2026-06-02  4:50   ` Darrick J. Wong
2026-06-08 11:25   ` Carlos Maiolino
2026-06-01 12:43 ` [PATCH 2/5] xfs: remove im_len field in struct xfs_imap Christoph Hellwig
2026-06-02  4:43   ` Darrick J. Wong
2026-06-08 11:27   ` Carlos Maiolino
2026-06-01 12:43 ` [PATCH 3/5] xfs: massage xfs_imap_to_bp into xfs_read_icluster Christoph Hellwig
2026-06-02  4:47   ` Darrick J. Wong
2026-06-02  5:37     ` Christoph Hellwig
2026-06-08 11:32   ` Carlos Maiolino
2026-06-01 12:43 ` [PATCH 4/5] xfs: store an agbno in struct xfs_imap Christoph Hellwig
2026-06-02  4:49   ` Darrick J. Wong
2026-06-08 11:45   ` Carlos Maiolino
2026-06-01 12:43 ` [PATCH 5/5] xfs: mark struct xfs_imap as __packed Christoph Hellwig
2026-06-02  4:49   ` Darrick J. Wong
2026-06-08 11:53   ` Carlos Maiolino [this message]
2026-06-09  7:26 ` shrink struct xfs_imap Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiatHy6BS4LIXsU-@nidhogg.toxiclabs.cc \
    --to=cem@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox