Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Hongling Zeng <zenghongling@kylinos.cn>
Cc: cem@kernel.org, djwong@kernel.org, hans.holmberg@wdc.com,
	linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	zhongling0719@126.com
Subject: Re: [PATCH v2] xfs: check split_sectors validity before bio_split call
Date: Wed, 29 Jul 2026 01:29:13 -0700	[thread overview]
Message-ID: <amm52bj1VAe24OQG@infradead.org> (raw)
In-Reply-To: <20260729073418.63750-1-zenghongling@kylinos.cn>

On Wed, Jul 29, 2026 at 03:34:18PM +0800, Hongling Zeng wrote:
> Change the split_sectors check from !split_sectors to split_sectors <= 0
> to make the error handling explicit. While bio_split_rw_at() cannot return
> a negative error code for the current GC I/O path (GC I/O doesn't use
> REQ_ATOMIC/REQ_NOWAIT flags and has proper alignment), making the check
> explicit improves code clarity and makes the intent clear.
> 
> This also makes the code more robust for future maintenance if different
> I/O patterns are introduced.
> 
> Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn>

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>


      reply	other threads:[~2026-07-29  8:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29  7:34 [PATCH v2] xfs: check split_sectors validity before bio_split call Hongling Zeng
2026-07-29  8:29 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amm52bj1VAe24OQG@infradead.org \
    --to=hch@infradead.org \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hans.holmberg@wdc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zenghongling@kylinos.cn \
    --cc=zhongling0719@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox