From: Dan Carpenter <error27@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: [bug report] xfs: remove _XBF_LOGRECOVERY
Date: Thu, 13 Aug 2026 10:08:46 +0300 [thread overview]
Message-ID: <an1tftfCWcRXJfps@stanley.mountain> (raw)
Hello Christoph Hellwig,
Commit d80fe85bb2fc ("xfs: remove _XBF_LOGRECOVERY") from Jul 15,
2026, leads to the following Smatch complaint:
fs/xfs/xfs_buf.c:1066 xfs_buf_ioend_handle_error()
warn: variable dereferenced before check 'mp->m_log' (see line 1057)
fs/xfs/xfs_buf.c
1056 */
1057 if (xlog_is_shutdown(mp->m_log))
^^^^^^^^^
This was already dereferenced
1058 goto out_stale;
1059
1060 xfs_buf_ioerror_alert_ratelimited(bp);
1061
1062 /*
1063 * We're not going to bother about retrying this during recovery.
1064 * One strike!
1065 */
1066 if (mp->m_log && xlog_in_recovery(mp->m_log)) {
^^^^^^^^^
So probably this check can be removed.
1067 xfs_force_shutdown(mp, SHUTDOWN_META_IO_ERROR);
1068 return false;
This email is a free service from the Smatch-CI project [smatch.sf.net].
regards,
dan carpenter
reply other threads:[~2026-08-13 7:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an1tftfCWcRXJfps@stanley.mountain \
--to=error27@gmail.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox