[bug report] xfs: remove _XBF_LOGRECOVERY

[bug report] xfs: remove _XBF_LOGRECOVERY

[Dan Carpenter]

Hello Christoph Hellwig,

Commit d80fe85bb2fc ("xfs: remove _XBF_LOGRECOVERY") from Jul 15,
2026, leads to the following Smatch complaint:

    fs/xfs/xfs_buf.c:1066 xfs_buf_ioend_handle_error()
    warn: variable dereferenced before check 'mp->m_log' (see line 1057)

fs/xfs/xfs_buf.c
  1056		 */
  1057		if (xlog_is_shutdown(mp->m_log))
                                     ^^^^^^^^^
This was already dereferenced

  1058			goto out_stale;
  1059	
  1060		xfs_buf_ioerror_alert_ratelimited(bp);
  1061	
  1062		/*
  1063		 * We're not going to bother about retrying this during recovery.
  1064		 * One strike!
  1065		 */
  1066		if (mp->m_log && xlog_in_recovery(mp->m_log)) {
                    ^^^^^^^^^
So probably this check can be removed.

  1067			xfs_force_shutdown(mp, SHUTDOWN_META_IO_ERROR);
  1068			return false;

This email is a free service from the Smatch-CI project [smatch.sf.net].

regards,
dan carpenter