From: Carlos Maiolino <cem@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: don't flush and invalidate internal RT device twice in xfs_shutdown_devices
Date: Tue, 18 Aug 2026 11:31:18 +0200 [thread overview]
Message-ID: <aoQmUmoirdb_Cu0l@andromeda.toxiclabs.cc> (raw)
In-Reply-To: <20260720140921.2269927-1-hch@lst.de>
On Mon, Jul 20, 2026 at 04:09:21PM +0200, Christoph Hellwig wrote:
> Check for an internal RT device to remove a bit of extra work.
>
> Fixes: bdc03eb5f98f ("xfs: allow internal RT devices for zoned mode")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 63c4bcbe6c2b..d96f3781d791 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -445,7 +445,7 @@ xfs_shutdown_devices(
> blkdev_issue_flush(mp->m_logdev_targp->bt_bdev);
> invalidate_bdev(mp->m_logdev_targp->bt_bdev);
> }
> - if (mp->m_rtdev_targp) {
> + if (mp->m_rtdev_targp && mp->m_rtdev_targp != mp->m_ddev_targp) {
> blkdev_issue_flush(mp->m_rtdev_targp->bt_bdev);
> invalidate_bdev(mp->m_rtdev_targp->bt_bdev);
> }
Looks good too.
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> --
> 2.53.0
>
>
next prev parent reply other threads:[~2026-08-18 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 14:09 [PATCH] xfs: don't flush and invalidate internal RT device twice in xfs_shutdown_devices Christoph Hellwig
2026-07-21 9:13 ` Carlos Maiolino
2026-08-18 9:31 ` Carlos Maiolino [this message]
2026-08-21 7:35 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoQmUmoirdb_Cu0l@andromeda.toxiclabs.cc \
--to=cem@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox