* [PATCH] xfs: don't flush and invalidate internal RT device twice in xfs_shutdown_devices
@ 2026-07-20 14:09 Christoph Hellwig
2026-07-21 9:13 ` Carlos Maiolino
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Christoph Hellwig @ 2026-07-20 14:09 UTC (permalink / raw)
To: cem; +Cc: linux-xfs
Check for an internal RT device to remove a bit of extra work.
Fixes: bdc03eb5f98f ("xfs: allow internal RT devices for zoned mode")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 63c4bcbe6c2b..d96f3781d791 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -445,7 +445,7 @@ xfs_shutdown_devices(
blkdev_issue_flush(mp->m_logdev_targp->bt_bdev);
invalidate_bdev(mp->m_logdev_targp->bt_bdev);
}
- if (mp->m_rtdev_targp) {
+ if (mp->m_rtdev_targp && mp->m_rtdev_targp != mp->m_ddev_targp) {
blkdev_issue_flush(mp->m_rtdev_targp->bt_bdev);
invalidate_bdev(mp->m_rtdev_targp->bt_bdev);
}
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: don't flush and invalidate internal RT device twice in xfs_shutdown_devices
2026-07-20 14:09 [PATCH] xfs: don't flush and invalidate internal RT device twice in xfs_shutdown_devices Christoph Hellwig
@ 2026-07-21 9:13 ` Carlos Maiolino
2026-08-18 9:31 ` Carlos Maiolino
2026-08-21 7:35 ` Carlos Maiolino
2 siblings, 0 replies; 4+ messages in thread
From: Carlos Maiolino @ 2026-07-21 9:13 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-xfs
On Mon, Jul 20, 2026 at 04:09:21PM +0200, Christoph Hellwig wrote:
> Check for an internal RT device to remove a bit of extra work.
>
> Fixes: bdc03eb5f98f ("xfs: allow internal RT devices for zoned mode")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 63c4bcbe6c2b..d96f3781d791 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -445,7 +445,7 @@ xfs_shutdown_devices(
> blkdev_issue_flush(mp->m_logdev_targp->bt_bdev);
> invalidate_bdev(mp->m_logdev_targp->bt_bdev);
> }
> - if (mp->m_rtdev_targp) {
> + if (mp->m_rtdev_targp && mp->m_rtdev_targp != mp->m_ddev_targp) {
> blkdev_issue_flush(mp->m_rtdev_targp->bt_bdev);
> invalidate_bdev(mp->m_rtdev_targp->bt_bdev);
> }
> --
> 2.53.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: don't flush and invalidate internal RT device twice in xfs_shutdown_devices
2026-07-20 14:09 [PATCH] xfs: don't flush and invalidate internal RT device twice in xfs_shutdown_devices Christoph Hellwig
2026-07-21 9:13 ` Carlos Maiolino
@ 2026-08-18 9:31 ` Carlos Maiolino
2026-08-21 7:35 ` Carlos Maiolino
2 siblings, 0 replies; 4+ messages in thread
From: Carlos Maiolino @ 2026-08-18 9:31 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-xfs
On Mon, Jul 20, 2026 at 04:09:21PM +0200, Christoph Hellwig wrote:
> Check for an internal RT device to remove a bit of extra work.
>
> Fixes: bdc03eb5f98f ("xfs: allow internal RT devices for zoned mode")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 63c4bcbe6c2b..d96f3781d791 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -445,7 +445,7 @@ xfs_shutdown_devices(
> blkdev_issue_flush(mp->m_logdev_targp->bt_bdev);
> invalidate_bdev(mp->m_logdev_targp->bt_bdev);
> }
> - if (mp->m_rtdev_targp) {
> + if (mp->m_rtdev_targp && mp->m_rtdev_targp != mp->m_ddev_targp) {
> blkdev_issue_flush(mp->m_rtdev_targp->bt_bdev);
> invalidate_bdev(mp->m_rtdev_targp->bt_bdev);
> }
Looks good too.
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> --
> 2.53.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: don't flush and invalidate internal RT device twice in xfs_shutdown_devices
2026-07-20 14:09 [PATCH] xfs: don't flush and invalidate internal RT device twice in xfs_shutdown_devices Christoph Hellwig
2026-07-21 9:13 ` Carlos Maiolino
2026-08-18 9:31 ` Carlos Maiolino
@ 2026-08-21 7:35 ` Carlos Maiolino
2 siblings, 0 replies; 4+ messages in thread
From: Carlos Maiolino @ 2026-08-21 7:35 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-xfs
On Mon, 20 Jul 2026 16:09:21 +0200, Christoph Hellwig wrote:
> Check for an internal RT device to remove a bit of extra work.
>
>
Applied to for-next, thanks!
[1/1] xfs: don't flush and invalidate internal RT device twice in xfs_shutdown_devices
commit: 7fc296b379edc0fef83890097af3c9537fbf4364
Best regards,
--
Carlos Maiolino <cem@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-21 7:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-20 14:09 [PATCH] xfs: don't flush and invalidate internal RT device twice in xfs_shutdown_devices Christoph Hellwig
2026-07-21 9:13 ` Carlos Maiolino
2026-08-18 9:31 ` Carlos Maiolino
2026-08-21 7:35 ` Carlos Maiolino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox