From: Christoph Hellwig <hch@infradead.org>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-btrfs@vger.kernel.org, Anand Suveer Jain <asj@kernel.org>,
Chao Yu <chao@kernel.org>
Subject: Re: [PATCH 1/5] fstests: consolidate _require_fs_sysfs and _require_fs_sysfs_attr
Date: Mon, 14 Sep 2026 23:56:06 -0700 [thread overview]
Message-ID: <aqjsBs6QUtIukk05@infradead.org> (raw)
In-Reply-To: <20260914172509.3799016-2-zlang@kernel.org>
On Tue, Sep 15, 2026 at 01:25:05AM +0800, Zorro Lang wrote:
> There is heavy overlap between _require_fs_sysfs and
> _require_fs_sysfs_attr, and their ambiguous names make it difficult
> to tell them apart.
>
> So merge them into a single function with "_dev_" included in the
> name to distinguish per-device entries from other paths like
> /sys/fs/$FSTYP/features/.
I have a bit of a hard time understanding this message. From looking
at the diff this seems to:
- rename _has_fs_sysfs_attr to _has_fs_sysfs_dev_attr
- rename _get_fs_sysfs_attr to _get_fs_sysfs_dev_attr
- rename _set_fs_sysfs_attr to _set_fs_sysfs_dev_attr
- rename _require_fs_sysfs_attr to _require_fs_sysfs_dev_attr
- remove _require_fs_sysfs
right? Maybe spell that out and split the pure renames from code
removal?
next prev parent reply other threads:[~2026-09-15 6:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 17:25 [PATCH 0/5] Refactor *_fs_sysfs_* helpers Zorro Lang
2026-09-14 17:25 ` [PATCH 1/5] fstests: consolidate _require_fs_sysfs and _require_fs_sysfs_attr Zorro Lang
2026-09-15 6:56 ` Christoph Hellwig [this message]
2026-09-15 14:33 ` Zorro Lang
2026-09-14 17:25 ` [PATCH 2/5] common/sysfs: adjust function naming Zorro Lang
2026-09-15 6:57 ` Christoph Hellwig
2026-09-15 14:46 ` Zorro Lang
2026-09-14 17:25 ` [PATCH 3/5] common/rc: add helpers for /sys/fs/$FSTYP/features/ Zorro Lang
2026-09-14 17:25 ` [PATCH 4/5] common/rc: use common helper in _require_fanotify_ioerrors for f2fs Zorro Lang
2026-09-14 17:25 ` [PATCH 5/5] fstests: replace btrfs specific helpers with common sysfs helpers Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqjsBs6QUtIukk05@infradead.org \
--to=hch@infradead.org \
--cc=asj@kernel.org \
--cc=chao@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox