Re: [PATCH 1/5] fstests: consolidate _require_fs_sysfs and _require_fs_sysfs_attr

[Zorro Lang <zlang@kernel.org>]

On Mon, Sep 14, 2026 at 11:56:06PM -0700, Christoph Hellwig wrote:
> On Tue, Sep 15, 2026 at 01:25:05AM +0800, Zorro Lang wrote:
> > There is heavy overlap between _require_fs_sysfs and
> > _require_fs_sysfs_attr, and their ambiguous names make it difficult
> > to tell them apart.
> > 
> > So merge them into a single function with "_dev_" included in the
> > name to distinguish per-device entries from other paths like
> > /sys/fs/$FSTYP/features/.
> 
> I have a bit of a hard time understanding this message.  From looking
> at the diff this seems to:
> 
>  - rename _has_fs_sysfs_attr to _has_fs_sysfs_dev_attr
>  - rename _get_fs_sysfs_attr to _get_fs_sysfs_dev_attr
>  - rename _set_fs_sysfs_attr to _set_fs_sysfs_dev_attr
>  - rename _require_fs_sysfs_attr to _require_fs_sysfs_dev_attr
>  - remove _require_fs_sysfs

And remove _has_fs_sysfs.

> 
> right?  Maybe spell that out and split the pure renames from code
> removal?

Sure, that makes sense. I will incorporate the rename into PATCH 2/5 in
the next revision.

Thanks,
Zorro