[PATCH] xfs: remove redundant extra assert from xfs_zone_gc_query

[PATCH] xfs: remove redundant extra assert from xfs_zone_gc_query

[cem]

From: Carlos Maiolino <cem@kernel.org>

We initially assert that iter->next_startblock is lower or equal
than the total blocks in the rtg.  If we are in the later case
(next_startblock being equal to blocks in rtg) the conditional
right after the first assert, will jump out of the function.
After the conditional, the only remaining case is next_startblock
being lower than the rtg block count.  So the second assert seems
redundant to me.

Signed-off-by: Carlos Maiolino <cem@kernel.org>
---
 fs/xfs/xfs_zone_gc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_zone_gc.c b/fs/xfs/xfs_zone_gc.c
index cea5447a886d..00644d997963 100644
--- a/fs/xfs/xfs_zone_gc.c
+++ b/fs/xfs/xfs_zone_gc.c
@@ -337,7 +337,6 @@ xfs_zone_gc_query(
 	if (iter->next_startblock == rtg_blocks(rtg))
 		goto done;
 
-	ASSERT(iter->next_startblock < rtg_blocks(rtg));
 	ri_low.rm_startblock = iter->next_startblock;
 	memset(&ri_high, 0xFF, sizeof(ri_high));
 
-- 
2.56.0

Re: [PATCH] xfs: remove redundant extra assert from xfs_zone_gc_query

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>