Re: [PATCH 5/8] xfs: remove status parameter from several btree insert functions

[Eric Sandeen <sandeen@redhat.com>]

On 10/28/26 10:50 AM, Christoph Hellwig wrote:
> On Fri, Oct 16, 2026 at 02:29:05PM -0500, Eric Sandeen wrote:
>> xfs_btree_insert and its callers now have no need for the status
>> parameter; either they return error = 0 / status = 1, or nonzero error
>> and status 0. No caller evaluates the status variable, so remove that
>> parameter from these functions.
>>
>> As requested, convert all of the compound tests/assignments to discrete
>> lines.
> 
> Looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
> Although I agree with Darrick that spelling out the parameters would
> be helpful.
> 

thanks, agree but I dunno, seems like a dedicated patch to change /so many/
of them would be good instead of hitting this one just because ...

/*
 * Common btree core entry points.
 */
int xfs_btree_increment(struct xfs_btree_cur *, int, int *);
int xfs_btree_decrement(struct xfs_btree_cur *, int, int *);
int xfs_btree_lookup(struct xfs_btree_cur *, xfs_lookup_t, int *);
int xfs_btree_update(struct xfs_btree_cur *, union xfs_btree_rec *);
int xfs_btree_new_iroot(struct xfs_btree_cur *, int *, int *);
int xfs_btree_insert(struct xfs_btree_cur *, int *);
int xfs_btree_delete(struct xfs_btree_cur *, int *);
int xfs_btree_get_rec(struct xfs_btree_cur *, union xfs_btree_rec **, int *);
int xfs_btree_change_owner(struct xfs_btree_cur *cur, uint64_t new_owner,
                           struct list_head *buffer_list);

/*
 * btree block CRC helpers
 */
void xfs_btree_fsblock_calc_crc(struct xfs_buf *);
bool xfs_btree_fsblock_verify_crc(struct xfs_buf *);
void xfs_btree_agblock_calc_crc(struct xfs_buf *);
bool xfs_btree_agblock_verify_crc(struct xfs_buf *);

/*
 * Internal btree helpers also used by xfs_bmap.c.
 */
void xfs_btree_log_block(struct xfs_btree_cur *, struct xfs_buf *, uint32_t);
void xfs_btree_log_recs(struct xfs_btree_cur *, struct xfs_buf *, int, int);