From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: schwab@linux-m68k.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Don't use asm goto for put_user() with GCC 4.9
Date: Tue, 3 Nov 2020 20:22:35 +0100 [thread overview]
Message-ID: <04ba7852-be06-dcda-3f91-7739025035e2@csgroup.eu> (raw)
In-Reply-To: <20201103185829.GM2672@gate.crashing.org>
Le 03/11/2020 à 19:58, Segher Boessenkool a écrit :
> On Tue, Nov 03, 2020 at 03:43:55PM +0100, Christophe Leroy wrote:
>> Le 03/11/2020 à 14:29, Michael Ellerman a écrit :
>>> For now though let's just not use asm goto with GCC 4.9, to avoid this
>>> bug and any other issues we haven't noticed yet. Possibly in future we
>>> can find a smaller workaround.
>>
>> Is that https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58670 ?
>
> That was fixed in 4.8.1 (and all 4.9), so probably not.
>
Ok.
Regardless, using "asm_volatile_goto()" instead of "asm volatile goto()" fixes the issue it seems.
Christophe
next prev parent reply other threads:[~2020-11-03 19:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 13:29 [PATCH] powerpc: Don't use asm goto for put_user() with GCC 4.9 Michael Ellerman
2020-11-03 14:43 ` Christophe Leroy
2020-11-03 17:04 ` Christophe Leroy
2020-11-03 18:58 ` Segher Boessenkool
2020-11-03 19:22 ` Christophe Leroy [this message]
2020-11-04 11:04 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04ba7852-be06-dcda-3f91-7739025035e2@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=linuxppc-dev@ozlabs.org \
--cc=schwab@linux-m68k.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox