LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RFC] Attempt to clean up sigsuspend et al
Date: Sat, 12 Nov 2005 00:48:46 +0000	[thread overview]
Message-ID: <1131756526.27347.212.camel@baythorne.infradead.org> (raw)
In-Reply-To: <17269.14127.936147.778781@cargo.ozlabs.ibm.com>

On Sat, 2005-11-12 at 11:28 +1100, Paul Mackerras wrote:
> Ummm, I don't see where you save the non-volatile GPRs to the
> exception frame _before_ do_signal (called from within *_sigsuspend)
> copies them to the user stack...

Hm, yeah.

I suppose I could make a TIF_xxx flag make entry.S do that. It's not
massively pretty, but then it wasn't pretty beforehand either. At least
I'd have made the ppc32 and ppc64 code match, removed the assembly
wrappers for a bunch of syscalls, and shortened the syscall exit fast
path on ppc64. 

I'd probably still be removing more lines of code than I add, but I'm
not entirely convinced by the whole plan. What do you think?

Failing that, I'll just switch them both to do either what ppc32
currently does with sigreturn_exit() or what ppc64 does with returning
zero to take the ret_from_except path. Probably the former, since
pselect() and ppoll() will sometimes want to return zero without
invoking a signal handler.  And we can probably shorten the ppc64
syscall exit path anyway, either way. 

-- 
dwmw2

  reply	other threads:[~2005-11-12  0:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-11 21:37 [RFC] Attempt to clean up sigsuspend et al David Woodhouse
2005-11-12  0:28 ` Paul Mackerras
2005-11-12  0:48   ` David Woodhouse [this message]
2005-11-13  6:58     ` Paul Mackerras
2005-11-13  9:41       ` David Woodhouse
2005-11-13 10:09         ` Paul Mackerras
2005-11-13 11:58           ` David Woodhouse
2005-11-14  4:43             ` Paul Mackerras
2005-11-14 20:05               ` David Woodhouse
2005-11-15  0:19       ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1131756526.27347.212.camel@baythorne.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox