From: Paul Mackerras <paulus@samba.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RFC] Attempt to clean up sigsuspend et al
Date: Sun, 13 Nov 2005 21:09:06 +1100 [thread overview]
Message-ID: <17271.4290.486710.929502@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <1131874887.27347.221.camel@baythorne.infradead.org>
David Woodhouse writes:
> We don't need to do it on entry; we can do it on exit. If do_signal()
> sees that the nvgprs weren't saved in the pt_regs it's playing with,
> then it can set a new TIF_SAVENVPGRS_TO_SIG_FRAME bit. I don't think we
> even need to store a pointer saying where to put them -- the signal
> frame will always be at the top of the userspace stack.
Two problems with that: (1) for *sigsuspend, if do_signal returns 0,
then we need to go back and keep waiting, and (2) it doesn't handle
the other syscalls that need the full register set, such as fork,
clone etc. Also, for the *sigsuspend case, we need to pass the saved
signal set to do_signal, not NULL (as the call from the exception exit
path does).
Paul.
next prev parent reply other threads:[~2005-11-13 10:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-11 21:37 [RFC] Attempt to clean up sigsuspend et al David Woodhouse
2005-11-12 0:28 ` Paul Mackerras
2005-11-12 0:48 ` David Woodhouse
2005-11-13 6:58 ` Paul Mackerras
2005-11-13 9:41 ` David Woodhouse
2005-11-13 10:09 ` Paul Mackerras [this message]
2005-11-13 11:58 ` David Woodhouse
2005-11-14 4:43 ` Paul Mackerras
2005-11-14 20:05 ` David Woodhouse
2005-11-15 0:19 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17271.4290.486710.929502@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=dwmw2@infradead.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox