From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] windfarm_smu_sat.c: simplify around i2c_add_driver()
Date: Tue, 22 Aug 2006 13:27:03 +1000 [thread overview]
Message-ID: <1156217223.21752.61.camel@localhost.localdomain> (raw)
In-Reply-To: <20060821232223.GB5220@martell.zuzino.mipt.ru>
On Tue, 2006-08-22 at 03:22 +0400, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Oops ... :)
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> drivers/macintosh/windfarm_smu_sat.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> --- a/drivers/macintosh/windfarm_smu_sat.c
> +++ b/drivers/macintosh/windfarm_smu_sat.c
> @@ -397,12 +397,7 @@ static int wf_sat_detach(struct i2c_clie
>
> static int __init sat_sensors_init(void)
> {
> - int err;
> -
> - err = i2c_add_driver(&wf_sat_driver);
> - if (err < 0)
> - return err;
> - return 0;
> + return i2c_add_driver(&wf_sat_driver);
> }
>
> static void __exit sat_sensors_exit(void)
prev parent reply other threads:[~2006-08-22 3:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-21 23:22 [PATCH] windfarm_smu_sat.c: simplify around i2c_add_driver() Alexey Dobriyan
2006-08-22 3:27 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156217223.21752.61.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox