LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] windfarm_smu_sat.c: simplify around i2c_add_driver()
@ 2006-08-21 23:22 Alexey Dobriyan
  2006-08-22  3:27 ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2006-08-21 23:22 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linuxppc-dev

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 drivers/macintosh/windfarm_smu_sat.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

--- a/drivers/macintosh/windfarm_smu_sat.c
+++ b/drivers/macintosh/windfarm_smu_sat.c
@@ -397,12 +397,7 @@ static int wf_sat_detach(struct i2c_clie
 
 static int __init sat_sensors_init(void)
 {
-	int err;
-
-	err = i2c_add_driver(&wf_sat_driver);
-	if (err < 0)
-		return err;
-	return 0;
+	return i2c_add_driver(&wf_sat_driver);
 }
 
 static void __exit sat_sensors_exit(void)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] windfarm_smu_sat.c: simplify around i2c_add_driver()
  2006-08-21 23:22 [PATCH] windfarm_smu_sat.c: simplify around i2c_add_driver() Alexey Dobriyan
@ 2006-08-22  3:27 ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2006-08-22  3:27 UTC (permalink / raw)
  To: Alexey Dobriyan; +Cc: Andrew Morton, linuxppc-dev

On Tue, 2006-08-22 at 03:22 +0400, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

Oops ... :)

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> ---
> 
>  drivers/macintosh/windfarm_smu_sat.c |    7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> --- a/drivers/macintosh/windfarm_smu_sat.c
> +++ b/drivers/macintosh/windfarm_smu_sat.c
> @@ -397,12 +397,7 @@ static int wf_sat_detach(struct i2c_clie
>  
>  static int __init sat_sensors_init(void)
>  {
> -	int err;
> -
> -	err = i2c_add_driver(&wf_sat_driver);
> -	if (err < 0)
> -		return err;
> -	return 0;
> +	return i2c_add_driver(&wf_sat_driver);
>  }
>  
>  static void __exit sat_sensors_exit(void)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-08-22  3:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-21 23:22 [PATCH] windfarm_smu_sat.c: simplify around i2c_add_driver() Alexey Dobriyan
2006-08-22  3:27 ` Benjamin Herrenschmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox