From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: eeh bug
Date: Thu, 17 May 2007 14:46:24 +1000 [thread overview]
Message-ID: <1179377184.32247.274.camel@localhost.localdomain> (raw)
Hi Linas !
While debugging some other issues, I had a couple of oopses caused by
what looks like a bug in EEH:
When an RTAS PCI config space call returns all f's, we do an eeh error
check by calling eeh_dn_check_failure(pdn->node, NULL);
The problem is that second argument... NULL for the pci_dev *. It looks
like the EEH code will try to printk pci_name of that and later on
dereference it within eehd, thus causing an oops.
I'm not sure what's the best way to fix it and have no time to dig right
now though I suppose one could walk all PCI devices in the system to
look for a match with the dev node.
Though if for some reason we don't find a match, I think we should still
handle NULL's gracefully.
Cheers,
Ben.
next reply other threads:[~2007-05-17 4:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 4:46 Benjamin Herrenschmidt [this message]
2007-05-17 4:59 ` eeh bug Benjamin Herrenschmidt
2007-05-17 16:44 ` Linas Vepstas
2007-05-17 22:43 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1179377184.32247.274.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linas@austin.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox