* of_iomap confusion
@ 2007-11-12 5:07 Benjamin Herrenschmidt
0 siblings, 0 replies; only message in thread
From: Benjamin Herrenschmidt @ 2007-11-12 5:07 UTC (permalink / raw)
To: linuxppc-dev list
I just noticed this of_iomap() helper thing we have in prom_parse.c
nowadays.
It's a bit confusing as "iomap" is generally what we use to name the new
iomap interface (ioport_map, pci_iomap, ...) and that requires
-different- accessors than memory obtained from ioremap.
This I think this needs to be changed.
We should call it of_ioremap() or of_map_resource() and if we want an
of_iomap(), it should provide an iomap token, not an ioremap address
(they look the same on powerpc, but they shouldn't be mixed up).
Ben.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-11-12 5:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-12 5:07 of_iomap confusion Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox