From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: hibernation BookE patch
Date: Tue, 12 Jan 2010 13:34:08 +1100 [thread overview]
Message-ID: <1263263648.724.182.camel@pasglop> (raw)
Hi Anton !
For some reason I can't find that patch in my mailbox (just saw it on
patchwork :-)
Here's a quick review. Looks good but two things:
- Please make it swsusp_booke.c, 44x support is trivial and I don't
want to rename the file :-)
- Is there really an SDR1 register on FSL BookE ? It's supposed to be
the pointer to the hash table on server ...
- You probably should save/restore the TCR and ack pending crap DEC or
FIT interrupts in the TSR right before you kick the decrementer
- Nowadays, we still assume that the "loader" kernel is exactly the
same as the "loaded" kernel on resume ? If not, you may need to
save/restore IVORs, IVPR, ...
Cheers,
Ben.
reply other threads:[~2010-01-12 2:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263263648.724.182.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=cbouatmailru@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox