* hibernation BookE patch
@ 2010-01-12 2:34 Benjamin Herrenschmidt
0 siblings, 0 replies; only message in thread
From: Benjamin Herrenschmidt @ 2010-01-12 2:34 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev
Hi Anton !
For some reason I can't find that patch in my mailbox (just saw it on
patchwork :-)
Here's a quick review. Looks good but two things:
- Please make it swsusp_booke.c, 44x support is trivial and I don't
want to rename the file :-)
- Is there really an SDR1 register on FSL BookE ? It's supposed to be
the pointer to the hash table on server ...
- You probably should save/restore the TCR and ack pending crap DEC or
FIT interrupts in the TSR right before you kick the decrementer
- Nowadays, we still assume that the "loader" kernel is exactly the
same as the "loaded" kernel on resume ? If not, you may need to
save/restore IVORs, IVPR, ...
Cheers,
Ben.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-01-12 2:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-12 2:34 hibernation BookE patch Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox