Re: PowerMac G4 (Digital Audio)

Re: PowerMac G4 (Digital Audio)

[Johannes Berg]

> Your snd-aoa seems to support PowerMac3,4. Is it really tested?

I used to add only IDs that some people tested, until most things worked
and I wholesale added all of the ones found in Darwin.

> The reason I'm asking: people are having problems with sound on that
> machine. Even snd-powermac didn't function, but I believe these
> patches have helped:
> 
> http://ristosu.wippiespace.com/pub/alsa-tumbler-1.0.22.1-p15.diff
> http://ristosu.wippiespace.com/pub/alsa-tumbler-1.0.22.1-p16.diff

These patches are odd -- the first one adds something the second
removes? Am I supposed to look at the combination?

> The problem is that active state is inverted (i.e. 1) compared to
> other machines on inputs that detect a plug (and there is no
> audio-gpio-active-state in the device tree in gpio 15 and gpio16).
> Snd-powermac guessed wrong.
> 
> How do you handle these in your code?

Well, there is gpio-feature and gpio-pmf right now. I suspect you can
get things working by adding some overrides to ftr_gpio_init(). I guess
you want something like

get_gpio("keywest-gpio1", NULL,
         &lineout_mute_gpio,
         &lineout_mute_gpio_activestate);

on the PowerMac4,3, and something else for the headphone ...

But frankly, it's been so long that it's not all making perfect sense to
me right now. If you send me a tarball of /proc/device-tree/ maybe I can
take a look -- just looked at my collection and I don't have that one.

johannes

Re: PowerMac G4 (Digital Audio)

[Risto Suominen]

2010/12/5, Johannes Berg <johannes@sipsolutions.net>:
>
>> http://ristosu.wippiespace.com/pub/alsa-tumbler-1.0.22.1-p15.diff
>> http://ristosu.wippiespace.com/pub/alsa-tumbler-1.0.22.1-p16.diff
>
> These patches are odd -- the first one adds something the second
> removes? Am I supposed to look at the combination?
>
Not really, the second one adds gpio16 but still keeps gpio15.
>
> But frankly, it's been so long that it's not all making perfect sense to
> me right now. If you send me a tarball of /proc/device-tree/ maybe I can
> take a look -- just looked at my collection and I don't have that one.
>
> johannes
>
A device tree dump is located at
http://manulix.wikidot.com/hidden:device-tree-my_G4
The tarball can be wget-ted from
http://manulix.wikidot.com/local--files/hidden:device-tree-my-g4/device-tree.tar.bz2

Risto

Re: PowerMac G4 (Digital Audio)

[Johannes Berg]

On Tue, 2010-12-07 at 10:51 +0200, Risto Suominen wrote:
> 2010/12/5, Johannes Berg <johannes@sipsolutions.net>:
> >
> >> http://ristosu.wippiespace.com/pub/alsa-tumbler-1.0.22.1-p15.diff
> >> http://ristosu.wippiespace.com/pub/alsa-tumbler-1.0.22.1-p16.diff
> >
> > These patches are odd -- the first one adds something the second
> > removes? Am I supposed to look at the combination?
> >
> Not really, the second one adds gpio16 but still keeps gpio15.

Oh, so the change to "gpio1" was intended to be some wildcard?

> > But frankly, it's been so long that it's not all making perfect sense to
> > me right now. If you send me a tarball of /proc/device-tree/ maybe I can
> > take a look -- just looked at my collection and I don't have that one.

> A device tree dump

Hmm ok, it's not really making a lot of sense to me now either.

Can you hack the file I previously pointed out and see if that helps?

johannes

Re: PowerMac G4 (Digital Audio)

[Risto Suominen]

2010/12/7, Johannes Berg <johannes@sipsolutions.net>:
>
> Oh, so the change to "gpio1" was intended to be some wildcard?
>
Yes. I know, not very pretty.
>
> Can you hack the file I previously pointed out and see if that helps?
>
Well, I could try. Actually, I don't own a machine to test with.

So, as far as I can see, you don't have any special handling for this
machine, or any other either? And you don't look for these gpio15 (hp)
and gpio16 (lo). They are the detect inputs, not mute outputs. So can
they cause such problems that no sound is played? Hmm...

One solution could be to just remove the support from snd-aoa and
continue using snd-powermac. Now it's difficult because of the
auto-loading.

Risto

Re: PowerMac G4 (Digital Audio)

[Johannes Berg]

On Tue, 2010-12-07 at 13:27 +0200, Risto Suominen wrote:

> > Can you hack the file I previously pointed out and see if that helps?
> >
> Well, I could try. Actually, I don't own a machine to test with.

Oh, ok... I thought you did.

> So, as far as I can see, you don't have any special handling for this
> machine, or any other either? And you don't look for these gpio15 (hp)
> and gpio16 (lo). They are the detect inputs, not mute outputs. So can
> they cause such problems that no sound is played? Hmm...

Right, normally we don't need any special handling since the DT has the
right names ... this machine just needs an override for the GPIO names
(gpio15/16 rather than the proper detect names).

> One solution could be to just remove the support from snd-aoa and
> continue using snd-powermac. Now it's difficult because of the
> auto-loading.

Yeah, not really ... I wrote aoa, so I guess I'm biased, but really
snd-powermac is quite a mess.

johannes

Re: PowerMac G4 (Digital Audio)

[Risto Suominen]

2010/12/7, Johannes Berg <johannes@sipsolutions.net>:
>
> Right, normally we don't need any special handling since the DT has the
> right names ... this machine just needs an override for the GPIO names
> (gpio15/16 rather than the proper detect names).
>
And setting the active-state manually to 1.

Risto

Re: PowerMac G4 (Digital Audio)

[Johannes Berg]

On Tue, 2010-12-07 at 13:41 +0200, Risto Suominen wrote:
> 2010/12/7, Johannes Berg <johannes@sipsolutions.net>:
> >
> > Right, normally we don't need any special handling since the DT has the
> > right names ... this machine just needs an override for the GPIO names
> > (gpio15/16 rather than the proper detect names).
> >
> And setting the active-state manually to 1.

Yes, I guess, it doesn't look like they have the typical property in the
DT for these.

johannes