[PATCH] fsl-rio: Release rapidio port I/O region resource if port failed to initialize

[PATCH] fsl-rio: Release rapidio port I/O region resource if port failed to initialize

[Liu Gang]

The "struct rio_mport" contains a member of master port I/O memory resource structure
"struct resource iores". This resource will be read from device tree and be used for
rapidio R/W transaction memory space. Rapidio requests the port I/O memory resource
under the root resource "iomem_resource".
			
			struct rio_mport *port;
			port = kzalloc(sizeof(struct rio_mport), GFP_KERNEL);

			request_resource(&iomem_resource, &port->iores);

When port failed to initialize, allocated "rio_mport" structure memory will be freed,
and the port I/O memory resource structure pointer "&port->iores" will be invalid. If
other requests resource under "iomem_resource", "&port->iores" node may be operated in
the child resources list and this will cause the system to crash.

So the requested port I/O memory resource should be released before freeing allocated
"rio_mport" structure.

Signed-off-by: Liu Gang <Gang.Liu@freescale.com>
---
 arch/powerpc/sysdev/fsl_rio.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c
index c65f75a..22ffccd 100644
--- a/arch/powerpc/sysdev/fsl_rio.c
+++ b/arch/powerpc/sysdev/fsl_rio.c
@@ -1608,6 +1608,7 @@ int fsl_rio_setup(struct platform_device *dev)
 	return 0;
 err:
 	iounmap(priv->regs_win);
+	release_resource(&port->iores);
 err_res:
 	kfree(priv);
 err_priv:
-- 
1.7.3.1

RE: [PATCH] fsl-rio: Release rapidio port I/O region resource if portfailed to initialize

[Bounine, Alexandre]

On Thursday, September 01, 2011 5:52 AM
Liu Gang <Gang.Liu@freescale.com> wrote:

> Subject: [PATCH] fsl-rio: Release rapidio port I/O region resource if
> portfailed to initialize
>=20
...
>=20
> Signed-off-by: Liu Gang <Gang.Liu@freescale.com>
> ---
>  arch/powerpc/sysdev/fsl_rio.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>=20
> diff --git a/arch/powerpc/sysdev/fsl_rio.c
> b/arch/powerpc/sysdev/fsl_rio.c
> index c65f75a..22ffccd 100644
> --- a/arch/powerpc/sysdev/fsl_rio.c
> +++ b/arch/powerpc/sysdev/fsl_rio.c
> @@ -1608,6 +1608,7 @@ int fsl_rio_setup(struct platform_device *dev)
>  	return 0;
>  err:
>  	iounmap(priv->regs_win);
> +	release_resource(&port->iores);
>  err_res:
>  	kfree(priv);
>  err_priv:
> --
> 1.7.3.1

Acked-by: Alexandre Bounine <alexandre.bounine@idt.com>