* [PATCH] kgdb: Removed kmalloc returned value cast
@ 2013-03-10 13:06 Alex Grad
2013-03-10 14:10 ` Pekka Enberg
0 siblings, 1 reply; 3+ messages in thread
From: Alex Grad @ 2013-03-10 13:06 UTC (permalink / raw)
To: benh
Cc: mikey, fr, linux-kernel, tiejun.chen, paulus, Alex Grad,
jason.wessel, linuxppc-dev
Signed-off-by: Alex Grad <alex.grad@gmail.com>
---
arch/powerpc/kernel/kgdb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c
index 5ca82cd..c1eef24 100644
--- a/arch/powerpc/kernel/kgdb.c
+++ b/arch/powerpc/kernel/kgdb.c
@@ -159,7 +159,7 @@ static int kgdb_singlestep(struct pt_regs *regs)
if (user_mode(regs))
return 0;
- backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct thread_info), GFP_KERNEL);
+ backup_current_thread_info = kmalloc(sizeof(struct thread_info), GFP_KERNEL);
/*
* On Book E and perhaps other processors, singlestep is handled on
* the critical exception stack. This causes current_thread_info()
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kgdb: Removed kmalloc returned value cast
2013-03-10 13:06 [PATCH] kgdb: Removed kmalloc returned value cast Alex Grad
@ 2013-03-10 14:10 ` Pekka Enberg
2013-03-10 19:05 ` Daniel Baluta
0 siblings, 1 reply; 3+ messages in thread
From: Pekka Enberg @ 2013-03-10 14:10 UTC (permalink / raw)
To: Alex Grad
Cc: mikey, fr, linux-kernel, tiejun.chen, paulus, jason.wessel,
linuxppc-dev
On Sun, Mar 10, 2013 at 3:06 PM, Alex Grad <alex.grad@gmail.com> wrote:
> Signed-off-by: Alex Grad <alex.grad@gmail.com>
> ---
> arch/powerpc/kernel/kgdb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c
> index 5ca82cd..c1eef24 100644
> --- a/arch/powerpc/kernel/kgdb.c
> +++ b/arch/powerpc/kernel/kgdb.c
> @@ -159,7 +159,7 @@ static int kgdb_singlestep(struct pt_regs *regs)
> if (user_mode(regs))
> return 0;
>
> - backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct thread_info), GFP_KERNEL);
> + backup_current_thread_info = kmalloc(sizeof(struct thread_info), GFP_KERNEL);
Looks good to me.
There's two additional problems in the kgdb_singlestep() function: it
doesn't check if the kmalloc() call fails nor does it kfree() the
allocated memory.
Pekka
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kgdb: Removed kmalloc returned value cast
2013-03-10 14:10 ` Pekka Enberg
@ 2013-03-10 19:05 ` Daniel Baluta
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Baluta @ 2013-03-10 19:05 UTC (permalink / raw)
To: Pekka Enberg
Cc: mikey, fr, linux-kernel, tiejun.chen, paulus, Alex Grad,
jason.wessel, linuxppc-dev
On Sun, Mar 10, 2013 at 4:10 PM, Pekka Enberg <penberg@kernel.org> wrote:
> On Sun, Mar 10, 2013 at 3:06 PM, Alex Grad <alex.grad@gmail.com> wrote:
>> Signed-off-by: Alex Grad <alex.grad@gmail.com>
>> ---
>> arch/powerpc/kernel/kgdb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c
>> index 5ca82cd..c1eef24 100644
>> --- a/arch/powerpc/kernel/kgdb.c
>> +++ b/arch/powerpc/kernel/kgdb.c
>> @@ -159,7 +159,7 @@ static int kgdb_singlestep(struct pt_regs *regs)
>> if (user_mode(regs))
>> return 0;
>>
>> - backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct thread_info), GFP_KERNEL);
>> + backup_current_thread_info = kmalloc(sizeof(struct thread_info), GFP_KERNEL);
>
> Looks good to me.
>
> There's two additional problems in the kgdb_singlestep() function: it
> doesn't check if the kmalloc() call fails nor does it kfree() the
> allocated memory.
Hi Pekka,
Indeed there is no check if kmalloc() fails. This should be fixed.
Anyhow, commit fefd9e6f powerpc: kernel/kgdb.c: Fix memory leakage
fixed the problem with kfree.
thanks,
Daniel.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-10 19:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-10 13:06 [PATCH] kgdb: Removed kmalloc returned value cast Alex Grad
2013-03-10 14:10 ` Pekka Enberg
2013-03-10 19:05 ` Daniel Baluta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox