* [PATCH] arch: powerpc: platforms: cell: cbe_thermal.c: Cleaning up a variable is of the wrong type
@ 2014-06-14 16:25 Rickard Strandqvist
2014-06-14 16:25 ` Rickard Strandqvist
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2014-06-14 16:25 UTC (permalink / raw)
To: Arnd Bergmann, Benjamin Herrenschmidt
Cc: cbe-oss-dev, linuxppc-dev, Paul Mackerras, linux-kernel,
Rickard Strandqvist
This variable is of the wrong type, everywhere it is used it
should be an unsigned int rather than a int.
This was partly found using a static code analysis program called cppcheck.
Rickard Strandqvist (1):
arch: powerpc: platforms: cell: cbe_thermal.c: Cleaning up a variable is of the wrong type
arch/powerpc/platforms/cell/cbe_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] arch: powerpc: platforms: cell: cbe_thermal.c: Cleaning up a variable is of the wrong type
2014-06-14 16:25 [PATCH] arch: powerpc: platforms: cell: cbe_thermal.c: Cleaning up a variable is of the wrong type Rickard Strandqvist
@ 2014-06-14 16:25 ` Rickard Strandqvist
0 siblings, 0 replies; 2+ messages in thread
From: Rickard Strandqvist @ 2014-06-14 16:25 UTC (permalink / raw)
To: Arnd Bergmann, Benjamin Herrenschmidt
Cc: cbe-oss-dev, linuxppc-dev, Paul Mackerras, linux-kernel,
Rickard Strandqvist
This variable is of the wrong type, everywhere it is used it
should be an unsigned int rather than a int.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
arch/powerpc/platforms/cell/cbe_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/cell/cbe_thermal.c b/arch/powerpc/platforms/cell/cbe_thermal.c
index 94560db..2c15ff0 100644
--- a/arch/powerpc/platforms/cell/cbe_thermal.c
+++ b/arch/powerpc/platforms/cell/cbe_thermal.c
@@ -125,7 +125,7 @@ static ssize_t show_throttle(struct cbe_pmd_regs __iomem *pmd_regs, char *buf, i
static ssize_t store_throttle(struct cbe_pmd_regs __iomem *pmd_regs, const char *buf, size_t size, int pos)
{
u64 reg_value;
- int temp;
+ unsigned int temp;
u64 new_value;
int ret;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-14 16:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-14 16:25 [PATCH] arch: powerpc: platforms: cell: cbe_thermal.c: Cleaning up a variable is of the wrong type Rickard Strandqvist
2014-06-14 16:25 ` Rickard Strandqvist
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox