* [PATCH] soc: fsl: qe: check platform_driver_register() in qe_ic_of_init()
@ 2026-07-31 9:46 Linkai Gong
2026-07-31 9:49 ` Maxim Kochetkov
2026-08-03 13:05 ` Christophe Leroy (CS GROUP)
0 siblings, 2 replies; 3+ messages in thread
From: Linkai Gong @ 2026-07-31 9:46 UTC (permalink / raw)
To: Qiang Zhao, Christophe Leroy
Cc: Li Yang, Maxim Kochetkov, Saravana Kannan, linuxppc-dev,
linux-arm-kernel, linux-kernel, Linkai Gong
qe_ic_of_init() ignored the return value of platform_driver_register()
and always returned success. Propagate the error to the initcall.
Fixes: be7ecbd240b2 ("soc: fsl: qe: convert QE interrupt controller to platform_device")
Signed-off-by: Linkai Gong <gonglinkai@kylinos.cn>
---
drivers/soc/fsl/qe/qe_ic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c
index 943911053af6..bccc7d612009 100644
--- a/drivers/soc/fsl/qe/qe_ic.c
+++ b/drivers/soc/fsl/qe/qe_ic.c
@@ -473,7 +473,6 @@ static struct platform_driver qe_ic_driver =
static int __init qe_ic_of_init(void)
{
- platform_driver_register(&qe_ic_driver);
- return 0;
+ return platform_driver_register(&qe_ic_driver);
}
subsys_initcall(qe_ic_of_init);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: fsl: qe: check platform_driver_register() in qe_ic_of_init()
2026-07-31 9:46 [PATCH] soc: fsl: qe: check platform_driver_register() in qe_ic_of_init() Linkai Gong
@ 2026-07-31 9:49 ` Maxim Kochetkov
2026-08-03 13:05 ` Christophe Leroy (CS GROUP)
1 sibling, 0 replies; 3+ messages in thread
From: Maxim Kochetkov @ 2026-07-31 9:49 UTC (permalink / raw)
To: Linkai Gong, Qiang Zhao, Christophe Leroy
Cc: Li Yang, Saravana Kannan, linuxppc-dev, linux-arm-kernel,
linux-kernel
31.07.2026 12:46, Linkai Gong wrote:
> qe_ic_of_init() ignored the return value of platform_driver_register()
> and always returned success. Propagate the error to the initcall.
>
> Fixes: be7ecbd240b2 ("soc: fsl: qe: convert QE interrupt controller to platform_device")
> Signed-off-by: Linkai Gong <gonglinkai@kylinos.cn>
Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: fsl: qe: check platform_driver_register() in qe_ic_of_init()
2026-07-31 9:46 [PATCH] soc: fsl: qe: check platform_driver_register() in qe_ic_of_init() Linkai Gong
2026-07-31 9:49 ` Maxim Kochetkov
@ 2026-08-03 13:05 ` Christophe Leroy (CS GROUP)
1 sibling, 0 replies; 3+ messages in thread
From: Christophe Leroy (CS GROUP) @ 2026-08-03 13:05 UTC (permalink / raw)
To: Qiang Zhao, Linkai Gong
Cc: Christophe Leroy, Li Yang, Maxim Kochetkov, Saravana Kannan,
linuxppc-dev, linux-arm-kernel, linux-kernel
On Fri, 31 Jul 2026 17:46:08 +0800, Linkai Gong wrote:
> qe_ic_of_init() ignored the return value of platform_driver_register()
> and always returned success. Propagate the error to the initcall.
>
>
Applied, thanks!
[1/1] soc: fsl: qe: check platform_driver_register() in qe_ic_of_init()
commit: 060325071fab5d889740f6393e4e8ecd990e6cd1
Best regards,
--
Christophe Leroy (CS GROUP) <chleroy@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-03 13:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-31 9:46 [PATCH] soc: fsl: qe: check platform_driver_register() in qe_ic_of_init() Linkai Gong
2026-07-31 9:49 ` Maxim Kochetkov
2026-08-03 13:05 ` Christophe Leroy (CS GROUP)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox