2.6.10-rc3 for 8xx with I2C config enabled compiles now ...

2.6.10-rc3 for 8xx with I2C config enabled compiles now ...

[Povolotsky, Alexander]

Hi Tom,

I have made the following configuration being "compilable" on 2.6.10-rc3
*********** .config ************
CONFIG_I2C=y
CONFIG_I2C_CHARDEV=y

#
# I2C Algorithms
#
CONFIG_I2C_ALGOBIT=y
.........
CONFIG_I2C_ALGO8XX=y

#
# I2C Hardware Bus support
#
..............
CONFIG_I2C_RPXLITE=y
............
#
# Hardware Sensors Chip support
#
CONFIG_I2C_SENSOR=y
.............
*********** .config ************

by following changes:

1) i2c-algo-8xx.h is copied from 2.4(.26) and placed into
./include/linux/i2c-algo-8xx.h

2) i2c-algo-8xx.c is copied from 2.4(.26) and placed into
./drivers/i2c/algos/i2c-algo-8xx.c

3) added into ./drivers/i2c/algos/Makefile 
   after existing line:
   obj-$(CONFIG_I2C_ALGOITE)       += i2c-algo-ite.o
   the following new line:
   obj-$(CONFIG_I2C_ALGO8XX)       += i2c-algo-8xx.o

4) added into ./include/asm-ppc/commproc.h
   after existing line:
   extern void cpm_free_handler(int vec);
   the following new line:
   extern const char *cpm_int_name[];

5) in ./drivers/i2c/busses/i2c-rpx.c
   changed the order of include files: 
   moving the line:
   #include <asm/commproc.h>
   to be above the line:
   #include <linux/i2c-algo-8xx.h>

   so now includes are in the following order:
   ...
#include <linux/config.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/stddef.h>
#include <linux/i2c.h>
#include <asm/commproc.h>
#include <linux/i2c-algo-8xx.h>
#include <asm/mpc8xx.h>
   ...
 
Thanks,
Alex 
-----Original Message-----
From: Tom Rini [mailto:trini@kernel.crashing.org]
Sent: Friday, December 17, 2004 12:09 PM
To: Povolotsky, Alexander
Subject: Re: 2.6.10-rc3 for 8xx with I2C config enabled still fails ...


On Fri, Dec 17, 2004 at 11:58:30AM -0500, Povolotsky, Alexander wrote:

So, your best bet to get 8xx I2C working is to grab the 'latest' from a
2.4 tree that has it working, and move it up.  In doing so, you may want
to kill 'i2c-rpx' and merge it all into the i2c-algo-8xx file.
So, I've attached the newest i2c-algo-8xx.h I can find.  The rest of the
code that's in 2.6 is probably good enough.  With this, hopefully you
can hack things into working (if you need a very simple i2c test
program, let me know.  I _think_ i have one around that should give you
the temp info found at least on my old rpxlite).

-- 
Tom Rini
http://gate.crashing.org/~trini/

Re: 2.6.10-rc3 for 8xx with I2C config enabled compiles now ...

[Tom Rini]

On Mon, Dec 20, 2004 at 01:44:04PM -0500, Povolotsky, Alexander wrote:

> Hi Tom,
> 
> I have made the following configuration being "compilable" on 2.6.10-rc3

Great! Would you mind posting a patch vs 2.6.10-rc3 (See
Documentation/SubmittingPatches) ?  Thanks.

-- 
Tom Rini
http://gate.crashing.org/~trini/