* parsing of some early cmdline options
@ 2006-02-23 23:02 Kumar Gala
2006-02-23 23:19 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 4+ messages in thread
From: Kumar Gala @ 2006-02-23 23:02 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras; +Cc: linuxppc-dev
Guys,
I noticed that we have code in arch/powerpc/kernel/prom_init.c to handle
parsing iommu=, mem=, and crashkernel=.
The problem I have is that we only use/build prom_init.c on MULTIPLATFORM
(coming from true OF).
Any ideas on how to handle this for the !MULTIPLATFORM cases. I'm most
concerned about mem=.
- kumar
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: parsing of some early cmdline options
2006-02-23 23:02 parsing of some early cmdline options Kumar Gala
@ 2006-02-23 23:19 ` Benjamin Herrenschmidt
2006-02-23 23:40 ` Michael Ellerman
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2006-02-23 23:19 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
On Thu, 2006-02-23 at 17:02 -0600, Kumar Gala wrote:
> Guys,
>
> I noticed that we have code in arch/powerpc/kernel/prom_init.c to handle
> parsing iommu=, mem=, and crashkernel=.
>
> The problem I have is that we only use/build prom_init.c on MULTIPLATFORM
> (coming from true OF).
MULTIPLATFORM is here to die (or rather be always there, with
ARCH=powerpc we really want to NOT reproduce the old single platform
crap) , but yes, prom_init.c is supposed to only be run on real OFs...
I suppose we woul have to deal with those in early_init_devtree() for
machines that didn't go through prom_init()....
> Any ideas on how to handle this for the !MULTIPLATFORM cases. I'm most
> concerned about mem=.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: parsing of some early cmdline options
2006-02-23 23:19 ` Benjamin Herrenschmidt
@ 2006-02-23 23:40 ` Michael Ellerman
2006-02-24 7:14 ` Kumar Gala
0 siblings, 1 reply; 4+ messages in thread
From: Michael Ellerman @ 2006-02-23 23:40 UTC (permalink / raw)
To: linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On Fri, 24 Feb 2006 10:19, Benjamin Herrenschmidt wrote:
> On Thu, 2006-02-23 at 17:02 -0600, Kumar Gala wrote:
> > Guys,
> >
> > I noticed that we have code in arch/powerpc/kernel/prom_init.c to handle
> > parsing iommu=, mem=, and crashkernel=.
> >
> > The problem I have is that we only use/build prom_init.c on MULTIPLATFORM
> > (coming from true OF).
> > Any ideas on how to handle this for the !MULTIPLATFORM cases. I'm most
> > concerned about mem=.
mem= is a bit tricky because you need to know about it really early, otherwise
your bootloader might violate the limit. But we could certainly check for it
again in prom.c. And you can always just set /chosen/linux,memory-limit.
cheers
--
Michael Ellerman
IBM OzLabs
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: parsing of some early cmdline options
2006-02-23 23:40 ` Michael Ellerman
@ 2006-02-24 7:14 ` Kumar Gala
0 siblings, 0 replies; 4+ messages in thread
From: Kumar Gala @ 2006-02-24 7:14 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev
On Feb 23, 2006, at 5:40 PM, Michael Ellerman wrote:
> On Fri, 24 Feb 2006 10:19, Benjamin Herrenschmidt wrote:
>> On Thu, 2006-02-23 at 17:02 -0600, Kumar Gala wrote:
>>> Guys,
>>>
>>> I noticed that we have code in arch/powerpc/kernel/prom_init.c to
>>> handle
>>> parsing iommu=, mem=, and crashkernel=.
>>>
>>> The problem I have is that we only use/build prom_init.c on
>>> MULTIPLATFORM
>>> (coming from true OF).
>
>>> Any ideas on how to handle this for the !MULTIPLATFORM cases.
>>> I'm most
>>> concerned about mem=.
>
> mem= is a bit tricky because you need to know about it really
> early, otherwise
> your bootloader might violate the limit. But we could certainly
> check for it
> again in prom.c. And you can always just set /chosen/linux,memory-
> limit.
Agreed, I'm looking at adding "early" cmd_line parsing in
early_init_dt_scan_chosen(). I assume we agree that mem= on command
line overrides "linux,memory-limit". I guessing that "linux,memory-
limit" is only ever created in prom_init.c which would be from a mem=
parsing.
- k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-02-24 7:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-23 23:02 parsing of some early cmdline options Kumar Gala
2006-02-23 23:19 ` Benjamin Herrenschmidt
2006-02-23 23:40 ` Michael Ellerman
2006-02-24 7:14 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox