LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] powerpc: Avoid __initcall warnings
@ 2006-04-02 10:18 Anton Blanchard
  0 siblings, 0 replies; only message in thread
From: Anton Blanchard @ 2006-04-02 10:18 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: paulus


Fix __initcall return in proc_rtas_init and rtas_init.

Signed-off-by: Anton Blanchard <anton@samba.org>
---

Index: build/arch/powerpc/kernel/rtas-proc.c
===================================================================
--- build.orig/arch/powerpc/kernel/rtas-proc.c	2006-03-30 10:08:47.000000000 +1100
+++ build/arch/powerpc/kernel/rtas-proc.c	2006-04-02 19:57:41.000000000 +1000
@@ -258,11 +258,11 @@ static int __init proc_rtas_init(void)
 	struct proc_dir_entry *entry;
 
 	if (!machine_is(pseries))
-		return 1;
+		return -ENODEV;
 
 	rtas_node = of_find_node_by_name(NULL, "rtas");
 	if (rtas_node == NULL)
-		return 1;
+		return -ENODEV;
 
 	entry = create_proc_entry("ppc64/rtas/progress", S_IRUGO|S_IWUSR, NULL);
 	if (entry)
Index: build/arch/powerpc/platforms/pseries/rtasd.c
===================================================================
--- build.orig/arch/powerpc/platforms/pseries/rtasd.c	2006-03-30 10:08:47.000000000 +1100
+++ build/arch/powerpc/platforms/pseries/rtasd.c	2006-04-02 20:14:50.000000000 +1000
@@ -488,7 +488,7 @@ static int __init rtas_init(void)
 	/* No RTAS */
 	if (rtas_token("event-scan") == RTAS_UNKNOWN_SERVICE) {
 		printk(KERN_INFO "rtasd: no event-scan on system\n");
-		return 1;
+		return -ENODEV;
 	}
 
 	entry = create_proc_entry("ppc64/rtas/error_log", S_IRUSR, NULL);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-04-02 10:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-02 10:18 [PATCH] powerpc: Avoid __initcall warnings Anton Blanchard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox