asdf

asdf

[Horms]

I have been looking at unifying the way that panic_on_oops logs
what it is doing between the different architectures that implement it.
The first cab off the rank is the patch below which removes a seemingly
silly difference between the behaviour on 32 and 64 bit powerpc.

I have not been able to test this as I do not have a ppc64 machine
at my disposal. However I did test that it compiles thanks to
the wonders of crosstool.

Signed-Off-By: Horms <horms@verge.net.au>

 arch/powerpc/kernel/traps.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
index 52f5659..908231a 100644
--- a/arch/powerpc/kernel/traps.c
+++ b/arch/powerpc/kernel/traps.c
@@ -157,10 +157,8 @@ #endif
 		panic("Fatal exception in interrupt");
 
 	if (panic_on_oops) {
-#ifdef CONFIG_PPC64
 		printk(KERN_EMERG "Fatal exception: panic in 5 seconds\n");
 		ssleep(5);
-#endif
 		panic("Fatal exception");
 	}
 	do_exit(err);

Re: [PATCH] powerpc: unify 32 and 64bit panic_on_oops messages

[Horms]

First up, sorry for the silly subject in the original post, that was an
error.

Secondly, when I sent the x86_64 version of this patch Andi Kleen
pointed out that calling ssleep() will just cause an early panic if the
code is in interrupt context. Accordingly, I plan to post patches to
remoove the ssleep(). So please ignore the patch that is bellow.

Thanks

-- 
Horms                                           
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

On Thu, 6 Jul 2006 19:15:22 +0900, Horms wrote:
> I have been looking at unifying the way that panic_on_oops logs
> what it is doing between the different architectures that implement it.
> The first cab off the rank is the patch below which removes a seemingly
> silly difference between the behaviour on 32 and 64 bit powerpc.
> 
> I have not been able to test this as I do not have a ppc64 machine
> at my disposal. However I did test that it compiles thanks to
> the wonders of crosstool.
> 
> Signed-Off-By: Horms <horms@verge.net.au>
> 
> arch/powerpc/kernel/traps.c |    2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
> index 52f5659..908231a 100644
> --- a/arch/powerpc/kernel/traps.c
> +++ b/arch/powerpc/kernel/traps.c
> @@ -157,10 +157,8 @@ #endif
> 		panic("Fatal exception in interrupt");
> 
> 	if (panic_on_oops) {
> -#ifdef CONFIG_PPC64
> 		printk(KERN_EMERG "Fatal exception: panic in 5 seconds\n");
> 		ssleep(5);
> -#endif
> 		panic("Fatal exception");
> 	}
> 	do_exit(err);