multicast for 8260 for 2.6.13

multicast for 8260 for 2.6.13

[Harnois Anne-Sophie]

Hello

In the file arch/ppc/8260_io/fcc_enet.c, set_multicast_list function is
commented out and I can't figure out why.=20
I checked the code, removed the comments and tried it, and multicast
seemed to work properly.=20

What am I missing?
Could someone explain me why this is commented out?

Many thanks,
Anne-Sophie

Re: multicast for 8260 for 2.6.13

[Vitaly Bordug]

On Thu, 20 Jul 2006 16:45:11 +0200
"Harnois Anne-Sophie" <anne-sophie.harnois@thomson.net> wrote:

> Hello
> 
> In the file arch/ppc/8260_io/fcc_enet.c, set_multicast_list function is
> commented out and I can't figure out why. 
> I checked the code, removed the comments and tried it, and multicast
> seemed to work properly. 
> 
> What am I missing?
> Could someone explain me why this is commented out?
The reason is because the arch/ppc/8260_io/* is deprecated by drivers/net/fs_enet, hence
people switched to use it...



-- 
Sincerely, 
Vitaly

Re: multicast for 8260 for 2.6.13

[Dan Malek]

On Jul 20, 2006, at 10:45 AM, Harnois Anne-Sophie wrote:

> In the file arch/ppc/8260_io/fcc_enet.c, set_multicast_list  
> function is
> commented out and I can't figure out why.

Read the mailing list archives.

> I checked the code, removed the comments and tried it, and multicast
> seemed to work properly.

Sorry, but that code will never work on a 82xx.

> What am I missing?
> Could someone explain me why this is commented out?

Because it was copied from the 8xx many years ago when
I ported the driver, and the 82xx lacks the CRC generator
support.  You can enable promiscuous mode, which is
what I suspect you did, and then the Linux IP stack will
do the multicast filtering.

By the way, this driver is obsolete and you should be
using the version in drivers/net/fs_enet.


Thanks.

	-- Dan