* [POWERPC] iSeries: supress lparmap.c warning
@ 2006-12-18 5:14 Stephen Rothwell
2006-12-18 10:41 ` Segher Boessenkool
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2006-12-18 5:14 UTC (permalink / raw)
To: paulus; +Cc: ppc-dev
lparmap.c: Assembler messages:
lparmap.c:43: Warning: ignoring changed section attributes for .text
We do not need the .section ops in the generated .s file, so
just remove them.
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
arch/powerpc/kernel/Makefile | 7 +++++--
arch/powerpc/kernel/head_64.S | 2 +-
2 files changed, 6 insertions(+), 3 deletions(-)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile
index d2ded19..0f7cb0b 100644
--- a/arch/powerpc/kernel/Makefile
+++ b/arch/powerpc/kernel/Makefile
@@ -76,9 +76,12 @@ obj-y += iomap.o
endif
ifeq ($(CONFIG_PPC_ISERIES),y)
-extra-y += lparmap.s
-$(obj)/head_64.o: $(obj)/lparmap.s
+extra-y += lparmap.s lparmap1.s
+$(obj)/head_64.o: $(obj)/lparmap1.s
AFLAGS_head_64.o += -I$(obj)
+
+$(obj)/lparmap1.s: $(obj)/lparmap.s
+ @grep -v '\.section' $< >$@
endif
else
diff --git a/arch/powerpc/kernel/head_64.S b/arch/powerpc/kernel/head_64.S
index 71b1fe5..b34e173 100644
--- a/arch/powerpc/kernel/head_64.S
+++ b/arch/powerpc/kernel/head_64.S
@@ -1535,7 +1535,7 @@ fwnmi_data_area:
* both pSeries and iSeries */
#ifdef CONFIG_PPC_ISERIES
. = LPARMAP_PHYS
-#include "lparmap.s"
+#include "lparmap1.s"
/*
* This ".text" is here for old compilers that generate a trailing
* .note section when compiling .c files to .s
--
1.4.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [POWERPC] iSeries: supress lparmap.c warning
2006-12-18 5:14 [POWERPC] iSeries: supress lparmap.c warning Stephen Rothwell
@ 2006-12-18 10:41 ` Segher Boessenkool
0 siblings, 0 replies; 2+ messages in thread
From: Segher Boessenkool @ 2006-12-18 10:41 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: ppc-dev, paulus
> lparmap.c: Assembler messages:
> lparmap.c:43: Warning: ignoring changed section attributes for .text
>
> We do not need the .section ops in the generated .s file, so
> just remove them.
Nasty stuff.
const struct LparMap __attribute__((__section__(".text"))) xLparMap = {
This will declare the .text section as non-executable. Whoops.
Another way around this, which is perhaps a bit hacky but
doesn't require your post-processing, is to use
__section__(".text #")
which will cut off the compiler-generated "a" (where the assembler
wants "ax", which is the default) :-)
Segher
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-12-18 10:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-18 5:14 [POWERPC] iSeries: supress lparmap.c warning Stephen Rothwell
2006-12-18 10:41 ` Segher Boessenkool
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox