LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/4 v3] powerpc: document interface-type property
@ 2007-04-20 20:11 Kim Phillips
  2007-04-20 20:57 ` Kumar Gala
  0 siblings, 1 reply; 3+ messages in thread
From: Kim Phillips @ 2007-04-20 20:11 UTC (permalink / raw)
  To: linuxppc-dev

Since ucc_geth is being migrated to use the phylib, the existing
(undocumented) 'interface' property is being deprecated in favour
of a stringified version, 'interface-type'.

interface-type is maintained one-to-one with definitions
in include/linux/phy.h.  If not specified, "mii" is assumed.

Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
---
removed max-speed property, since the name is apparently too generic
(it's derived from the interface-type anyway)

 Documentation/powerpc/booting-without-of.txt |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt
index 88cdb59..e128282 100644
--- a/Documentation/powerpc/booting-without-of.txt
+++ b/Documentation/powerpc/booting-without-of.txt
@@ -1562,6 +1562,9 @@ platforms are moved over to use the flattened-device-tree model.
      network device.  This is used by the bootwrapper to interpret
      MAC addresses passed by the firmware when no information other
      than indices is available to associate an address with a device.
+   - interface-type : a string naming the controller/PHY interface type,
+     i.e., "mii" (default), "rmii", "gmii", "rgmii", "rgmii-id", "tbi",
+     or "rtbi".
 
    Example:
 	ucc@2000 {
@@ -1573,6 +1576,7 @@ platforms are moved over to use the flattened-device-tree model.
 		interrupts = <a0 0>;
 		interrupt-parent = <700>;
 		mac-address = [ 00 04 9f 00 23 23 ];
+		interface-type = "gmii";
 		rx-clock = "none";
 		tx-clock = "clk9";
 		phy-handle = <212000>;
-- 
1.5.0.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/4 v3] powerpc: document interface-type property
  2007-04-20 20:11 [PATCH 1/4 v3] powerpc: document interface-type property Kim Phillips
@ 2007-04-20 20:57 ` Kumar Gala
  2007-04-20 21:34   ` Andy Fleming
  0 siblings, 1 reply; 3+ messages in thread
From: Kumar Gala @ 2007-04-20 20:57 UTC (permalink / raw)
  To: Kim Phillips; +Cc: linuxppc-dev


On Apr 20, 2007, at 3:11 PM, Kim Phillips wrote:

> Since ucc_geth is being migrated to use the phylib, the existing
> (undocumented) 'interface' property is being deprecated in favour
> of a stringified version, 'interface-type'.
>
> interface-type is maintained one-to-one with definitions
> in include/linux/phy.h.  If not specified, "mii" is assumed.
>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> removed max-speed property, since the name is apparently too generic
> (it's derived from the interface-type anyway)

Are you sure?  Is not possible to use a gmii phy on a 8323 and limit  
it to 10/100?

- k

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/4 v3] powerpc: document interface-type property
  2007-04-20 20:57 ` Kumar Gala
@ 2007-04-20 21:34   ` Andy Fleming
  0 siblings, 0 replies; 3+ messages in thread
From: Andy Fleming @ 2007-04-20 21:34 UTC (permalink / raw)
  To: Kumar Gala; +Cc: linuxppc-dev


On Apr 20, 2007, at 15:57, Kumar Gala wrote:

>
> On Apr 20, 2007, at 3:11 PM, Kim Phillips wrote:
>
>> Since ucc_geth is being migrated to use the phylib, the existing
>> (undocumented) 'interface' property is being deprecated in favour
>> of a stringified version, 'interface-type'.
>>
>> interface-type is maintained one-to-one with definitions
>> in include/linux/phy.h.  If not specified, "mii" is assumed.
>>
>> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
>> ---
>> removed max-speed property, since the name is apparently too generic
>> (it's derived from the interface-type anyway)
>
> Are you sure?  Is not possible to use a gmii phy on a 8323 and limit
> it to 10/100?


Ahem.  Just to maintain this point: It's not a GMII PHY.  It would be  
a PHY that supports the GMII interface.  In this case, we would  
specify that the controller is connecting to its PHY over interface- 
type "mii".  The real issue (right now) would be an RGMII or SGMII  
connection for a non-gigabit controller.

However, the UCC doesn't currently support SGMII, and there aren't  
any implementations that have non-gigabit RGMII connections.

In other words, this could become an issue in the future, but we're  
punting on pushing through a specifier for that situation until it  
comes up.

Andy

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-04-20 21:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-20 20:11 [PATCH 1/4 v3] powerpc: document interface-type property Kim Phillips
2007-04-20 20:57 ` Kumar Gala
2007-04-20 21:34   ` Andy Fleming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox