* [PATCH] ppc: chipsfb.c build fix for CONFIG_PM
@ 2007-07-29 17:50 Mariusz Kozlowski
2007-07-29 21:33 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Mariusz Kozlowski @ 2007-07-29 17:50 UTC (permalink / raw)
To: paulus, Andrew Morton, pavel, rjw; +Cc: linuxppc-dev, linux-kernel
Hello,
This patch fixes the following build error on powerpc:
CC drivers/video/chipsfb.o
drivers/video/chipsfb.c: In function 'chipsfb_pci_suspend':
drivers/video/chipsfb.c:461: error: 'PM_SUSPEND_MEM' undeclared (first use in this function)
drivers/video/chipsfb.c:461: error: (Each undeclared identifier is reported only once
drivers/video/chipsfb.c:461: error: for each function it appears in.)
make[2]: *** [drivers/video/chipsfb.o] Blad 1
make[1]: *** [drivers/video] Blad 2
make: *** [drivers] Blad 2
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
drivers/video/chipsfb.c | 12751 -> 12804 (+53 bytes)
drivers/video/chipsfb.o | -> 112880 ( bytes)
drivers/video/chipsfb.c | 5 +++++
1 file changed, 5 insertions(+)
--- linux-2.6.23-rc1-mm1-a/drivers/video/chipsfb.c 2007-07-26 13:07:41.000000000 +0200
+++ linux-2.6.23-rc1-mm1-b/drivers/video/chipsfb.c 2007-07-29 19:34:15.000000000 +0200
@@ -27,6 +27,11 @@
#include <linux/init.h>
#include <linux/pci.h>
#include <linux/console.h>
+
+#ifdef CONFIG_PM
+#include <linux/suspend.h>
+#endif
+
#include <asm/io.h>
#ifdef CONFIG_PMAC_BACKLIGHT
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ppc: chipsfb.c build fix for CONFIG_PM
2007-07-29 17:50 [PATCH] ppc: chipsfb.c build fix for CONFIG_PM Mariusz Kozlowski
@ 2007-07-29 21:33 ` Rafael J. Wysocki
2007-07-29 21:31 ` Mariusz Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2007-07-29 21:33 UTC (permalink / raw)
To: Mariusz Kozlowski
Cc: linuxppc-dev, Andrew Morton, paulus, pavel, linux-kernel
On Sunday, 29 July 2007 19:50, Mariusz Kozlowski wrote:
> Hello,
>
> This patch fixes the following build error on powerpc:
>
> CC drivers/video/chipsfb.o
> drivers/video/chipsfb.c: In function 'chipsfb_pci_suspend':
> drivers/video/chipsfb.c:461: error: 'PM_SUSPEND_MEM' undeclared (first use in this function)
> drivers/video/chipsfb.c:461: error: (Each undeclared identifier is reported only once
> drivers/video/chipsfb.c:461: error: for each function it appears in.)
> make[2]: *** [drivers/video/chipsfb.o] Blad 1
> make[1]: *** [drivers/video] Blad 2
> make: *** [drivers] Blad 2
Already fixed in the right way. Please see:
http://www.mail-archive.com/mm-commits@vger.kernel.org/msg22171.html
Greetings,
Rafael
--
"Premature optimization is the root of all evil." - Donald Knuth
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ppc: chipsfb.c build fix for CONFIG_PM
2007-07-29 21:33 ` Rafael J. Wysocki
@ 2007-07-29 21:31 ` Mariusz Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Mariusz Kozlowski @ 2007-07-29 21:31 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: linuxppc-dev, Andrew Morton, paulus, pavel, linux-kernel
> > This patch fixes the following build error on powerpc:
> >
> > CC drivers/video/chipsfb.o
> > drivers/video/chipsfb.c: In function 'chipsfb_pci_suspend':
> > drivers/video/chipsfb.c:461: error: 'PM_SUSPEND_MEM' undeclared (first use in this function)
> > drivers/video/chipsfb.c:461: error: (Each undeclared identifier is reported only once
> > drivers/video/chipsfb.c:461: error: for each function it appears in.)
> > make[2]: *** [drivers/video/chipsfb.o] Blad 1
> > make[1]: *** [drivers/video] Blad 2
> > make: *** [drivers] Blad 2
>
> Already fixed in the right way. Please see:
> http://www.mail-archive.com/mm-commits@vger.kernel.org/msg22171.html
Ah... ok. Didn't see that.
Thanks,
Mariusz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-29 21:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-29 17:50 [PATCH] ppc: chipsfb.c build fix for CONFIG_PM Mariusz Kozlowski
2007-07-29 21:33 ` Rafael J. Wysocki
2007-07-29 21:31 ` Mariusz Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox