public inbox for linuxppc-dev@ozlabs.org
 help / color / mirror / Atom feed
* dtc: Make make print a message when linking testcases
@ 2007-08-31  6:04 David Gibson
  2007-08-31 13:38 ` Jon Loeliger
  0 siblings, 1 reply; 2+ messages in thread
From: David Gibson @ 2007-08-31  6:04 UTC (permalink / raw)
  To: Jon Loeliger; +Cc: linuxppc-dev

Currently, dtc relies on make's implicit rule to build the testcases.
This means that when not making verbosely (V=0, the default) there is
no message at all while relinking the testsuites.  This can be very
confusing when updating libfdt.a (upon which the testcases depend) and
make appears to do nothing.

This patch corrects the situation, borrowing the rule used to link dtc
itself to link all the testcases as well.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Index: dtc/Makefile
===================================================================
--- dtc.orig/Makefile	2007-08-31 15:58:40.000000000 +1000
+++ dtc/Makefile	2007-08-31 15:58:59.000000000 +1000
@@ -101,8 +101,6 @@
 	$(LEX) $<
 
 dtc: $(DTC_OBJS)
-	@$(VECHO) LD $@
-	$(LINK.c) -o $@ $^
 
 ftdump:	ftdump.o
 
@@ -168,6 +166,10 @@
 #
 # Generic compile rules
 #
+%: %.o
+	@$(VECHO) LD $@
+	$(LINK.c) -o $@ $^
+
 %.o: %.c
 	@$(VECHO) CC $@
 	$(CC) $(CPPFLAGS) $(CFLAGS) -o $@ -c $<

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: dtc: Make make print a message when linking testcases
  2007-08-31  6:04 dtc: Make make print a message when linking testcases David Gibson
@ 2007-08-31 13:38 ` Jon Loeliger
  0 siblings, 0 replies; 2+ messages in thread
From: Jon Loeliger @ 2007-08-31 13:38 UTC (permalink / raw)
  To: David Gibson; +Cc: linuxppc-dev

So, like, the other day David Gibson mumbled:
> Currently, dtc relies on make's implicit rule to build the testcases.
> This means that when not making verbosely (V=0, the default) there is
> no message at all while relinking the testsuites.  This can be very
> confusing when updating libfdt.a (upon which the testcases depend) and
> make appears to do nothing.
> 
> This patch corrects the situation, borrowing the rule used to link dtc
> itself to link all the testcases as well.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Applied.

Thanks,
jdl

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-31 13:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-31  6:04 dtc: Make make print a message when linking testcases David Gibson
2007-08-31 13:38 ` Jon Loeliger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox