From: "Mark A. Greer" <mgreer@mvista.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev <Linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 1/2] powerpc: prpmc2800 - Add MTD support
Date: Thu, 25 Oct 2007 18:06:23 -0700 [thread overview]
Message-ID: <20071026010623.GA12823@mag.az.mvista.com> (raw)
In-Reply-To: <20071026102353.b837423b.sfr@canb.auug.org.au>
On Fri, Oct 26, 2007 at 10:23:53AM +1000, Stephen Rothwell wrote:
> Hi Mark,
>
> On Thu, 25 Oct 2007 16:39:48 -0700 "Mark A. Greer" <mgreer@mvista.com> wrote:
> >
> > +static int __init prpmc2800_register_mtd(void)
> > +{
> > + struct device_node *np = NULL;
> ^^^^^^^
> Not needed if you use for_each_compatible_node().
>
> > +
> > + while ((np = of_find_compatible_node(np, NULL, "cfi-flash")) != NULL)
>
> for_each_compatible_node(np, NULL, "cfi-flash")
>
> > + of_platform_device_create(np, NULL, NULL);
> > +
> > + of_node_put(np);
>
> Not needed as np must be NULL when you get here.
Ah, yes, true on all points. Thanks Stephen.
Update coming shortly...
Mark
next prev parent reply other threads:[~2007-10-26 1:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 23:39 [PATCH 1/2] powerpc: prpmc2800 - Add MTD support Mark A. Greer
2007-10-25 23:42 ` [PATCH 2/2] powerpc: prpmc2800 - Don't overwrite user FLASH size Mark A. Greer
2007-10-26 0:23 ` [PATCH 1/2] powerpc: prpmc2800 - Add MTD support Stephen Rothwell
2007-10-26 1:06 ` Mark A. Greer [this message]
2007-10-26 2:19 ` [PATCH v2 " Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071026010623.GA12823@mag.az.mvista.com \
--to=mgreer@mvista.com \
--cc=Linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox