LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [POWERPC] pasemi: Fix module information for gpio-mdio
@ 2007-12-03  4:40 Olof Johansson
  2007-12-03  4:46 ` Paul Mackerras
  0 siblings, 1 reply; 3+ messages in thread
From: Olof Johansson @ 2007-12-03  4:40 UTC (permalink / raw)
  To: linuxppc-dev

[POWERPC] pasemi: Fix module information for gpio-mdio
    
Fix up the module information for gpio-mdio, it wouldn't load
because of lacking license, and wouldn't auto-load because of missing
MODULE_DEVICE_TABLE.
    
Signed-off-by: Olof Johansson <olof@lixom.net>

diff --git a/arch/powerpc/platforms/pasemi/gpio_mdio.c b/arch/powerpc/platforms/pasemi/gpio_mdio.c
index b029804..04a8686 100644
--- a/arch/powerpc/platforms/pasemi/gpio_mdio.c
+++ b/arch/powerpc/platforms/pasemi/gpio_mdio.c
@@ -318,6 +318,7 @@ static struct of_device_id gpio_mdio_match[] =
 	},
 	{},
 };
+MODULE_DEVICE_TABLE(of, gpio_mdio_match);
 
 static struct of_platform_driver gpio_mdio_driver =
 {
@@ -356,3 +357,7 @@ void gpio_mdio_exit(void)
 		iounmap(gpio_regs);
 }
 module_exit(gpio_mdio_exit);
+
+MODULE_LICENSE("GPL");
+MODULE_AUTHOR("Olof Johansson <olof@lixom.net>");
+MODULE_DESCRIPTION("Driver for MDIO over GPIO on PA Semi PWRficient-based boards");

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] [POWERPC] pasemi: Fix module information for gpio-mdio
  2007-12-03  4:40 [PATCH] [POWERPC] pasemi: Fix module information for gpio-mdio Olof Johansson
@ 2007-12-03  4:46 ` Paul Mackerras
  2007-12-03  4:58   ` Olof Johansson
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Mackerras @ 2007-12-03  4:46 UTC (permalink / raw)
  To: Olof Johansson; +Cc: linuxppc-dev

Olof Johansson writes:

> Fix up the module information for gpio-mdio, it wouldn't load
> because of lacking license, and wouldn't auto-load because of missing
> MODULE_DEVICE_TABLE.

Needed for 2.6.24?

Paul.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] [POWERPC] pasemi: Fix module information for gpio-mdio
  2007-12-03  4:46 ` Paul Mackerras
@ 2007-12-03  4:58   ` Olof Johansson
  0 siblings, 0 replies; 3+ messages in thread
From: Olof Johansson @ 2007-12-03  4:58 UTC (permalink / raw)
  To: Paul Mackerras; +Cc: linuxppc-dev

On Mon, Dec 03, 2007 at 03:46:34PM +1100, Paul Mackerras wrote:
> Olof Johansson writes:
> 
> > Fix up the module information for gpio-mdio, it wouldn't load
> > because of lacking license, and wouldn't auto-load because of missing
> > MODULE_DEVICE_TABLE.
> 
> Needed for 2.6.24?

It's annoying but not critical, and the workaround is simple (build it
in). I've already queued it up in my for-2.6.25 git branch, that should
be sufficient.


Thanks,

Olof

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-12-03  4:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-03  4:40 [PATCH] [POWERPC] pasemi: Fix module information for gpio-mdio Olof Johansson
2007-12-03  4:46 ` Paul Mackerras
2007-12-03  4:58   ` Olof Johansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox