* [PATCH] Do not fail build if mkimage is not available
@ 2007-12-23 19:31 Michael Buesch
2007-12-23 20:05 ` Josh Boyer
0 siblings, 1 reply; 3+ messages in thread
From: Michael Buesch @ 2007-12-23 19:31 UTC (permalink / raw)
To: paulus; +Cc: linuxppc-dev
This fixes the boot image wrapper script to not fail the kernel
build if mkimage is not available.
As some distributions don't ship the mkimage program and I am not
interested in uboot images anyway, I don't want to fail the whole kernel
build process because of this unneeded dependency.
Simply drop an error message, but don't fail the build.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Index: wireless-2.6/arch/powerpc/boot/wrapper
===================================================================
--- wireless-2.6.orig/arch/powerpc/boot/wrapper 2007-12-23 20:10:07.000000000 +0100
+++ wireless-2.6/arch/powerpc/boot/wrapper 2007-12-23 20:22:41.000000000 +0100
@@ -195,6 +195,14 @@ if [ -n "$version" ]; then
fi
case "$platform" in
+cuboot* | uboot)
+ if ! [ -x mkimage ]; then
+ echo "mkimage not available. Can not create $platform image."
+ exit 0
+ fi
+esac
+
+case "$platform" in
uboot)
rm -f "$ofile"
mkimage -A ppc -O linux -T kernel -C gzip -a 00000000 -e 00000000 \
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Do not fail build if mkimage is not available
2007-12-23 19:31 [PATCH] Do not fail build if mkimage is not available Michael Buesch
@ 2007-12-23 20:05 ` Josh Boyer
2007-12-23 21:21 ` Michael Buesch
0 siblings, 1 reply; 3+ messages in thread
From: Josh Boyer @ 2007-12-23 20:05 UTC (permalink / raw)
To: Michael Buesch; +Cc: linuxppc-dev, paulus
On Sun, 23 Dec 2007 20:31:08 +0100
Michael Buesch <mb@bu3sch.de> wrote:
> This fixes the boot image wrapper script to not fail the kernel
> build if mkimage is not available.
> As some distributions don't ship the mkimage program and I am not
> interested in uboot images anyway, I don't want to fail the whole kernel
> build process because of this unneeded dependency.
>
> Simply drop an error message, but don't fail the build.
This is probably OK for now, but I'm working on getting mkimage merged
into the kernel so it will just get ripped back out later if I'm
successful.
josh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Do not fail build if mkimage is not available
2007-12-23 20:05 ` Josh Boyer
@ 2007-12-23 21:21 ` Michael Buesch
0 siblings, 0 replies; 3+ messages in thread
From: Michael Buesch @ 2007-12-23 21:21 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev, paulus
On Sunday 23 December 2007 21:05:16 Josh Boyer wrote:
> On Sun, 23 Dec 2007 20:31:08 +0100
> Michael Buesch <mb@bu3sch.de> wrote:
>
> > This fixes the boot image wrapper script to not fail the kernel
> > build if mkimage is not available.
> > As some distributions don't ship the mkimage program and I am not
> > interested in uboot images anyway, I don't want to fail the whole kernel
> > build process because of this unneeded dependency.
> >
> > Simply drop an error message, but don't fail the build.
>
> This is probably OK for now, but I'm working on getting mkimage merged
> into the kernel so it will just get ripped back out later if I'm
> successful.
Yeah, cool. I am fine with this. :)
I just don't want to install a tool into my operating system that
I do not need. Shipping it with the kernel is the best option.
--
Greetings Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-12-23 21:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-23 19:31 [PATCH] Do not fail build if mkimage is not available Michael Buesch
2007-12-23 20:05 ` Josh Boyer
2007-12-23 21:21 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox