[PATCH] PowerPC 44x: add missing define TARGET_4xx to cuboot-taishan.c

[PATCH] PowerPC 44x: add missing define TARGET_4xx to cuboot-taishan.c

[Valentine Barshak]

In order to get the proper bd_info structure for PowerPC 440,
both TARGET_4xx and TARGET_44x should be defined.

Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
---
 arch/powerpc/boot/cuboot-taishan.c |    1 +
 1 files changed, 1 insertion(+)

diff -pruN linux-2.6.orig/arch/powerpc/boot/cuboot-taishan.c linux-2.6/arch/powerpc/boot/cuboot-taishan.c
--- linux-2.6.orig/arch/powerpc/boot/cuboot-taishan.c	2008-02-21 16:46:11.000000000 +0300
+++ linux-2.6/arch/powerpc/boot/cuboot-taishan.c	2008-02-21 16:48:43.000000000 +0300
@@ -21,6 +21,7 @@
 #include "dcr.h"
 #include "4xx.h"
 
+#define TARGET_4xx
 #define TARGET_44x
 #include "ppcboot.h"
 

Re: [PATCH] PowerPC 44x: add missing define TARGET_4xx to cuboot-taishan.c

[Josh Boyer]

On Thu, 21 Feb 2008 17:43:17 +0300
Valentine Barshak <vbarshak@ru.mvista.com> wrote:

> In order to get the proper bd_info structure for PowerPC 440,
> both TARGET_4xx and TARGET_44x should be defined.

Could you explain what this adds or why it's needed in the changelog?
Also, is this needed for other 440 boards?

josh

Re: [PATCH] PowerPC 44x: add missing define TARGET_4xx to cuboot-taishan.c

[Josh Boyer]

On Sun, 24 Feb 2008 09:32:55 -0600
Josh Boyer <jwboyer@linux.vnet.ibm.com> wrote:

> On Thu, 21 Feb 2008 17:43:17 +0300
> Valentine Barshak <vbarshak@ru.mvista.com> wrote:
> 
> > In order to get the proper bd_info structure for PowerPC 440,
> > both TARGET_4xx and TARGET_44x should be defined.
> 
> Could you explain what this adds or why it's needed in the changelog?
> Also, is this needed for other 440 boards?

And actually, looking at this more, does taishan also need TARGET_440GX?

josh

[PATCH] PowerPC 44x: add missing define TARGET_4xx and TARGET_440GX to cuboot-taishan.c

[Valentine Barshak]

In order to get the proper boad info (bd_info) structure defined in ppcboot.h
both TARGET_4xx and TARGET_44x should be defined for all PowerPC 440 boards.
The 440GX boards also need TARGET_440GX defined since they have 4 EMACs and
there are 4 MAC addesses in bd_info passed by u-boot.

Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
---
 arch/powerpc/boot/cuboot-taishan.c |    2 ++
 1 files changed, 2 insertions(+)

diff -pruN linux-2.6.orig/arch/powerpc/boot/cuboot-taishan.c linux-2.6/arch/powerpc/boot/cuboot-taishan.c
--- linux-2.6.orig/arch/powerpc/boot/cuboot-taishan.c	2008-02-26 16:02:36.000000000 +0300
+++ linux-2.6/arch/powerpc/boot/cuboot-taishan.c	2008-02-26 16:21:08.000000000 +0300
@@ -21,7 +21,9 @@
 #include "dcr.h"
 #include "4xx.h"
 
+#define TARGET_4xx
 #define TARGET_44x
+#define TARGET_440GX
 #include "ppcboot.h"
 
 static bd_t bd;

Re: [PATCH] PowerPC 44x: add missing define TARGET_4xx and TARGET_440GX to cuboot-taishan.c

[Josh Boyer]

On Tue, 26 Feb 2008 17:58:53 +0300
Valentine Barshak <vbarshak@ru.mvista.com> wrote:

> In order to get the proper boad info (bd_info) structure defined in ppcboot.h
> both TARGET_4xx and TARGET_44x should be defined for all PowerPC 440 boards.
> The 440GX boards also need TARGET_440GX defined since they have 4 EMACs and
> there are 4 MAC addesses in bd_info passed by u-boot.

Thanks, looks much better.  I'll send this to Paul later today.

josh