* [PATCH] arch/powerpc/platforms/iseries/pci.c: Use time_* macros [not found] ` <1205746593-24820-3-git-send-email-caglar@pardus.org.tr> @ 2008-03-17 9:36 ` S.Çağlar Onur 2008-03-17 23:31 ` Stephen Rothwell 0 siblings, 1 reply; 2+ messages in thread From: S.Çağlar Onur @ 2008-03-17 9:36 UTC (permalink / raw) To: linux-kernel; +Cc: linuxppc-dev, Andrew Morton, Paul Mackerras The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly Cc: linuxppc-dev@ozlabs.org Cc: Paul Mackerras <paulus@samba.org> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr> --- arch/powerpc/platforms/iseries/pci.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/platforms/iseries/pci.c b/arch/powerpc/platforms/iseries/pci.c index cc562e4..02a634f 100644 --- a/arch/powerpc/platforms/iseries/pci.c +++ b/arch/powerpc/platforms/iseries/pci.c @@ -23,6 +23,7 @@ #undef DEBUG +#include <linux/jiffies.h> #include <linux/kernel.h> #include <linux/list.h> #include <linux/string.h> @@ -586,7 +587,7 @@ static inline struct device_node *xlate_iomm_address( static unsigned long last_jiffies; static int num_printed; - if ((jiffies - last_jiffies) > 60 * HZ) { + if (time_after(jiffies, last_jiffies + 60 * HZ)) { last_jiffies = jiffies; num_printed = 0; } -- 1.5.4.3 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arch/powerpc/platforms/iseries/pci.c: Use time_* macros 2008-03-17 9:36 ` [PATCH] arch/powerpc/platforms/iseries/pci.c: Use time_* macros S.Çağlar Onur @ 2008-03-17 23:31 ` Stephen Rothwell 0 siblings, 0 replies; 2+ messages in thread From: Stephen Rothwell @ 2008-03-17 23:31 UTC (permalink / raw) To: S.Çağlar Onur Cc: linuxppc-dev, Andrew Morton, Paul Mackerras, linux-kernel [-- Attachment #1: Type: text/plain, Size: 699 bytes --] On Mon, 17 Mar 2008 11:36:26 +0200 S.Çağlar Onur <caglar@pardus.org.tr> wrote: > > The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. > > So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly > > Cc: linuxppc-dev@ozlabs.org > Cc: Paul Mackerras <paulus@samba.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr> Acked-by: Stephen Rothwell <sfr@canb.auug.org.au> -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-17 23:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1205746593-24820-1-git-send-email-caglar@pardus.org.tr>
[not found] ` <1205746593-24820-2-git-send-email-caglar@pardus.org.tr>
[not found] ` <1205746593-24820-3-git-send-email-caglar@pardus.org.tr>
2008-03-17 9:36 ` [PATCH] arch/powerpc/platforms/iseries/pci.c: Use time_* macros S.Çağlar Onur
2008-03-17 23:31 ` Stephen Rothwell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox