* [PATCH] hotplug/rpaphp: remove unused error path code
@ 2008-08-19 1:45 Stephen Rothwell
2008-08-27 23:34 ` Jesse Barnes
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2008-08-19 1:45 UTC (permalink / raw)
To: Paul Mackerras
Cc: Alex Chiang, LKML, Jesse Barnes, linuxppc-dev, Linda Xie,
Andrew Morton
Commit f46753c5e354b857b20ab8e0fe7b2579831dc369 ("PCI: introduce pci_slot") removed the need for this error path. Eliminate this warning:
drivers/pci/hotplug/rpaphp_slot.c: In function 'rpaphp_register_slot':
drivers/pci/hotplug/rpaphp_slot.c:151: warning: label 'sysfs_fail' defined but not used
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/pci/hotplug/rpaphp_slot.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/hotplug/rpaphp_slot.c b/drivers/pci/hotplug/rpaphp_slot.c
index 9b714ea..5088450 100644
--- a/drivers/pci/hotplug/rpaphp_slot.c
+++ b/drivers/pci/hotplug/rpaphp_slot.c
@@ -147,9 +147,5 @@ int rpaphp_register_slot(struct slot *slot)
list_add(&slot->rpaphp_slot_list, &rpaphp_slot_head);
info("Slot [%s] registered\n", slot->name);
return 0;
-
-sysfs_fail:
- pci_hp_deregister(php_slot);
- return retval;
}
--
1.5.6.3
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hotplug/rpaphp: remove unused error path code
2008-08-19 1:45 [PATCH] hotplug/rpaphp: remove unused error path code Stephen Rothwell
@ 2008-08-27 23:34 ` Jesse Barnes
2008-08-28 3:16 ` Stephen Rothwell
0 siblings, 1 reply; 3+ messages in thread
From: Jesse Barnes @ 2008-08-27 23:34 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Alex Chiang, LKML, linuxppc-dev, Paul Mackerras, Linda Xie,
Andrew Morton
On Monday, August 18, 2008 6:45 pm Stephen Rothwell wrote:
> Commit f46753c5e354b857b20ab8e0fe7b2579831dc369 ("PCI: introduce pci_slot")
> removed the need for this error path. Eliminate this warning:
>
> drivers/pci/hotplug/rpaphp_slot.c: In function 'rpaphp_register_slot':
> drivers/pci/hotplug/rpaphp_slot.c:151: warning: label 'sysfs_fail' defined
> but not used
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Applied to linux-next, thanks.
Jesse
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hotplug/rpaphp: remove unused error path code
2008-08-27 23:34 ` Jesse Barnes
@ 2008-08-28 3:16 ` Stephen Rothwell
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2008-08-28 3:16 UTC (permalink / raw)
To: Jesse Barnes
Cc: Alex Chiang, LKML, linuxppc-dev, Paul Mackerras, Linda Xie,
Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 770 bytes --]
Hi Jesse,
On Wed, 27 Aug 2008 16:34:03 -0700 Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>
> On Monday, August 18, 2008 6:45 pm Stephen Rothwell wrote:
> > Commit f46753c5e354b857b20ab8e0fe7b2579831dc369 ("PCI: introduce pci_slot")
> > removed the need for this error path. Eliminate this warning:
> >
> > drivers/pci/hotplug/rpaphp_slot.c: In function 'rpaphp_register_slot':
> > drivers/pci/hotplug/rpaphp_slot.c:151: warning: label 'sysfs_fail' defined
> > but not used
> >
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Applied to linux-next, thanks.
I has also been applied to the powerpc next tree, but that is ok.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-08-28 3:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-19 1:45 [PATCH] hotplug/rpaphp: remove unused error path code Stephen Rothwell
2008-08-27 23:34 ` Jesse Barnes
2008-08-28 3:16 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox