From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Martyn Welch <martyn.welch@gefanuc.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH v2] powerpc: FPGA support for GE Fanuc SBC610
Date: Mon, 13 Oct 2008 20:38:50 +1100 [thread overview]
Message-ID: <20081013203850.9b600bd9.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20081013085202.15525.75859.stgit@ubuntu8041.localdomain>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
Hi Martyn,
On Mon, 13 Oct 2008 09:53:49 +0100 Martyn Welch <martyn.welch@gefanuc.com> wrote:
>
> --- a/arch/powerpc/platforms/86xx/gef_sbc610.c
> +++ b/arch/powerpc/platforms/86xx/gef_sbc610.c
> @@ -73,6 +73,7 @@ static void __init gef_sbc610_init_irq(void)
>
> static void __init gef_sbc610_setup_arch(void)
> {
> + struct device_node *regs;
> #ifdef CONFIG_PCI
> struct device_node *np;
>
> @@ -86,8 +87,42 @@ static void __init gef_sbc610_setup_arch(void)
> #ifdef CONFIG_SMP
> mpc86xx_smp_init();
> #endif
> +
> + /* Remap basic board registers */
> + regs = of_find_compatible_node(NULL, NULL, "gef,fpga-regs");
> + if (regs) {
> + sbc610_regs = of_iomap(regs, 0);
> + if (sbc610_regs == NULL)
> + printk(KERN_WARNING "Unable to map board registers\n");
You need an of_node_put(regs) here.
> + }
> +}
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2008-10-13 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 8:53 [PATCH v2] powerpc: FPGA support for GE Fanuc SBC610 Martyn Welch
2008-10-13 9:38 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081013203850.9b600bd9.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=martyn.welch@gefanuc.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox