LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dts-bindings/fsl/dma.txt: fix IRQ number in mpc83xx dma example
@ 2009-01-14 14:14 Peter Korsgaard
  2009-01-14 14:21 ` Anton Vorontsov
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2009-01-14 14:14 UTC (permalink / raw)
  To: galak, linuxppc-dev

The DMAC IRQ number of the mpc8349 is 71 and not 47, according to
http://www.freescale.com/files/32bit/doc/ref_manual/MPC8349EARMAD.pdf

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 Documentation/powerpc/dts-bindings/fsl/dma.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/powerpc/dts-bindings/fsl/dma.txt b/Documentation/powerpc/dts-bindings/fsl/dma.txt
index cc45311..3df1552 100644
--- a/Documentation/powerpc/dts-bindings/fsl/dma.txt
+++ b/Documentation/powerpc/dts-bindings/fsl/dma.txt
@@ -38,7 +38,7 @@ Example:
 		reg = <82a8 4>;
 		ranges = <0 8100 1a4>;
 		interrupt-parent = <&ipic>;
-		interrupts = <47 8>;
+		interrupts = <71 8>;
 		cell-index = <0>;
 		dma-channel@0 {
 			compatible = "fsl,mpc8349-dma-channel", "fsl,elo-dma-channel";
-- 
1.5.6.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dts-bindings/fsl/dma.txt: fix IRQ number in mpc83xx dma example
  2009-01-14 14:14 [PATCH] dts-bindings/fsl/dma.txt: fix IRQ number in mpc83xx dma example Peter Korsgaard
@ 2009-01-14 14:21 ` Anton Vorontsov
  2009-01-14 14:35   ` Kumar Gala
  2009-01-14 14:47   ` Peter Korsgaard
  0 siblings, 2 replies; 4+ messages in thread
From: Anton Vorontsov @ 2009-01-14 14:21 UTC (permalink / raw)
  To: Peter Korsgaard; +Cc: linuxppc-dev

Hi Peter,

On Wed, Jan 14, 2009 at 03:14:13PM +0100, Peter Korsgaard wrote:
> The DMAC IRQ number of the mpc8349 is 71 and not 47, according to
> http://www.freescale.com/files/32bit/doc/ref_manual/MPC8349EARMAD.pdf
> 
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> ---
>  Documentation/powerpc/dts-bindings/fsl/dma.txt |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/powerpc/dts-bindings/fsl/dma.txt b/Documentation/powerpc/dts-bindings/fsl/dma.txt
> index cc45311..3df1552 100644
> --- a/Documentation/powerpc/dts-bindings/fsl/dma.txt
> +++ b/Documentation/powerpc/dts-bindings/fsl/dma.txt
> @@ -38,7 +38,7 @@ Example:
>  		reg = <82a8 4>;
>  		ranges = <0 8100 1a4>;
>  		interrupt-parent = <&ipic>;
> -		interrupts = <47 8>;
> +		interrupts = <71 8>;

0x47 = 71 ;-) The example is in the dts-v0 format, all the numbers
are hexadecimal.

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dts-bindings/fsl/dma.txt: fix IRQ number in mpc83xx dma example
  2009-01-14 14:21 ` Anton Vorontsov
@ 2009-01-14 14:35   ` Kumar Gala
  2009-01-14 14:47   ` Peter Korsgaard
  1 sibling, 0 replies; 4+ messages in thread
From: Kumar Gala @ 2009-01-14 14:35 UTC (permalink / raw)
  To: avorontsov; +Cc: linuxppc-dev


On Jan 14, 2009, at 8:21 AM, Anton Vorontsov wrote:

> Hi Peter,
>
> On Wed, Jan 14, 2009 at 03:14:13PM +0100, Peter Korsgaard wrote:
>> The DMAC IRQ number of the mpc8349 is 71 and not 47, according to
>> http://www.freescale.com/files/32bit/doc/ref_manual/MPC8349EARMAD.pdf
>>
>> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
>> ---
>> Documentation/powerpc/dts-bindings/fsl/dma.txt |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/Documentation/powerpc/dts-bindings/fsl/dma.txt b/ 
>> Documentation/powerpc/dts-bindings/fsl/dma.txt
>> index cc45311..3df1552 100644
>> --- a/Documentation/powerpc/dts-bindings/fsl/dma.txt
>> +++ b/Documentation/powerpc/dts-bindings/fsl/dma.txt
>> @@ -38,7 +38,7 @@ Example:
>> 		reg = <82a8 4>;
>> 		ranges = <0 8100 1a4>;
>> 		interrupt-parent = <&ipic>;
>> -		interrupts = <47 8>;
>> +		interrupts = <71 8>;
>
> 0x47 = 71 ;-) The example is in the dts-v0 format, all the numbers
> are hexadecimal.

I'm all for changing the docs to dts-v1 syntax but if you are going to  
do that.  Do it completely for the file.

(reg, ranges, etc..)

- k

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dts-bindings/fsl/dma.txt: fix IRQ number in mpc83xx dma example
  2009-01-14 14:21 ` Anton Vorontsov
  2009-01-14 14:35   ` Kumar Gala
@ 2009-01-14 14:47   ` Peter Korsgaard
  1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2009-01-14 14:47 UTC (permalink / raw)
  To: avorontsov; +Cc: linuxppc-dev

>>>>> "Anton" == Anton Vorontsov <avorontsov@ru.mvista.com> writes:

Hi,

 >> interrupt-parent = <&ipic>;
 >> -		interrupts = <47 8>;
 >> +		interrupts = <71 8>;

 Anton> 0x47 = 71 ;-) The example is in the dts-v0 format, all the numbers
 Anton> are hexadecimal.

Ahh ;)

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-01-14 14:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-14 14:14 [PATCH] dts-bindings/fsl/dma.txt: fix IRQ number in mpc83xx dma example Peter Korsgaard
2009-01-14 14:21 ` Anton Vorontsov
2009-01-14 14:35   ` Kumar Gala
2009-01-14 14:47   ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox