* [PATCH] keywest: Get rid of useless i2c_device_name() macro
@ 2009-05-14 12:37 Jean Delvare
2009-05-14 12:43 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2009-05-14 12:37 UTC (permalink / raw)
To: alsa-devel; +Cc: Takashi Iwai, linuxppc-dev
The i2c_device_name() macro is used only once and doesn't have much
value, it hurts redability more than it helps. Get rid of it.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
sound/ppc/keywest.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--- linux-2.6.30-rc1.orig/sound/ppc/keywest.c 2009-04-10 16:22:08.000000000 +0200
+++ linux-2.6.30-rc1/sound/ppc/keywest.c 2009-04-10 16:25:16.000000000 +0200
@@ -33,10 +33,6 @@
static struct pmac_keywest *keywest_ctx;
-#ifndef i2c_device_name
-#define i2c_device_name(x) ((x)->name)
-#endif
-
static int keywest_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
@@ -56,7 +52,7 @@ static int keywest_attach_adapter(struct
if (! keywest_ctx)
return -EINVAL;
- if (strncmp(i2c_device_name(adapter), "mac-io", 6))
+ if (strncmp(adapter->name, "mac-io", 6))
return 0; /* ignored */
memset(&info, 0, sizeof(struct i2c_board_info));
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] keywest: Get rid of useless i2c_device_name() macro
2009-05-14 12:37 [PATCH] keywest: Get rid of useless i2c_device_name() macro Jean Delvare
@ 2009-05-14 12:43 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2009-05-14 12:43 UTC (permalink / raw)
To: Jean Delvare; +Cc: alsa-devel, linuxppc-dev
At Thu, 14 May 2009 14:37:21 +0200,
Jean Delvare wrote:
>
> The i2c_device_name() macro is used only once and doesn't have much
> value, it hurts redability more than it helps. Get rid of it.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Applied now. Thanks.
Takashi
> ---
> sound/ppc/keywest.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> --- linux-2.6.30-rc1.orig/sound/ppc/keywest.c 2009-04-10 16:22:08.000000000 +0200
> +++ linux-2.6.30-rc1/sound/ppc/keywest.c 2009-04-10 16:25:16.000000000 +0200
> @@ -33,10 +33,6 @@
> static struct pmac_keywest *keywest_ctx;
>
>
> -#ifndef i2c_device_name
> -#define i2c_device_name(x) ((x)->name)
> -#endif
> -
> static int keywest_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> @@ -56,7 +52,7 @@ static int keywest_attach_adapter(struct
> if (! keywest_ctx)
> return -EINVAL;
>
> - if (strncmp(i2c_device_name(adapter), "mac-io", 6))
> + if (strncmp(adapter->name, "mac-io", 6))
> return 0; /* ignored */
>
> memset(&info, 0, sizeof(struct i2c_board_info));
>
>
> --
> Jean Delvare
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-14 12:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-14 12:37 [PATCH] keywest: Get rid of useless i2c_device_name() macro Jean Delvare
2009-05-14 12:43 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox