[PATCH v2 2/2] EDAC: Remove deprecated bindings for MPC85xx

[PATCH v2 2/2] EDAC: Remove deprecated bindings for MPC85xx

[Bradley Hughes]

The "fsl,85..." style bindings for the l2-cache-controller
and memory-controller were intended to be deprected as of 2.6.30
per comment in drivers/edac/mpc85xx_edac.c.  Previous patch in this
series updates all DTS to use the "fsl,mpc85..." style binding
for these two nodes, allowing us to finally deprecate said
notation.

Signed-off-by: Bradley Hughes <bhughes@silicontkx.com>
---
 drivers/edac/mpc85xx_edac.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
index 52ca09b..50b319e 100644
--- a/drivers/edac/mpc85xx_edac.c
+++ b/drivers/edac/mpc85xx_edac.c
@@ -631,13 +631,6 @@ static int mpc85xx_l2_err_remove(struct of_device *op)
 }

 static struct of_device_id mpc85xx_l2_err_of_match[] = {
-/* deprecate the fsl,85.. forms in the future, 2.6.30? */
-	{ .compatible = "fsl,8540-l2-cache-controller", },
-	{ .compatible = "fsl,8541-l2-cache-controller", },
-	{ .compatible = "fsl,8544-l2-cache-controller", },
-	{ .compatible = "fsl,8548-l2-cache-controller", },
-	{ .compatible = "fsl,8555-l2-cache-controller", },
-	{ .compatible = "fsl,8568-l2-cache-controller", },
 	{ .compatible = "fsl,mpc8536-l2-cache-controller", },
 	{ .compatible = "fsl,mpc8540-l2-cache-controller", },
 	{ .compatible = "fsl,mpc8541-l2-cache-controller", },
-- 
1.7.0.4

Re: [PATCH v2 2/2] EDAC: Remove deprecated bindings for MPC85xx

[Scott Wood]

On Wed, 21 Jul 2010 18:04:10 -0400
Bradley Hughes <bhughes@silicontkx.com> wrote:

> The "fsl,85..." style bindings for the l2-cache-controller
> and memory-controller were intended to be deprected as of 2.6.30
> per comment in drivers/edac/mpc85xx_edac.c.

And yet they were only removed from the in-kernel dts files in patch
1/2.

> Previous patch in this
> series updates all DTS to use the "fsl,mpc85..." style binding
> for these two nodes, allowing us to finally deprecate said
> notation.

Please leave this around.  Once a binding is used, we try to stay
compatible with it when practical.  Not all device trees in use come
straight from arch/powerpc/boot/dts (consider custom boards, and
firmware device tree manipulation), and even those that do come
straihgt from the kernel tree are not necessarily rebuilt at the same
time as the kernel.

-Scott