Re: [PATCH v3 0/7] Fixup booting with device trees and uImage/elf on ppc32

Re: [PATCH v3 0/7] Fixup booting with device trees and uImage/elf on ppc32

[Simon Horman]

[Cced linuxppc-dev]

On Tue, Jul 20, 2010 at 11:42:57PM -0500, Matthew McClintock wrote:
> This patch series adds full support for booting with a flat device tree
> with either uImage or elf file formats. Kexec and Kdump should work, and
> you should also be able to use ramdisks or reuse your current ramdisk as well
> 
> This patch series was tested on an mpc85xx system with a kernel version
> 2.6.35-rc3
> 
> v1: Initial version
> 
> v2: Added support for fs2dt (file system to device tree)
> 
> v3: Fix some misc. git problems I had and other code cleanups

Hi Matthew,

I'm a little concerned that these changes are non trivial and haven't had
much review. But I am prepared to put them into my tree once 2.0.2 is
released - perhaps that way they will get some test coverage. Does
that work for you?

> 
> Matthew McClintock (7):
>   Restore kexec uImage-ppc to working state
>   Fix case where phys_addr_t != unsigned long when reading proc entries
>   Update uImage to support crash kernel and misc fixes
>   Update Elf-ppc to support crash kernel and misc fixes
>   Add support for ramdisk on ppc32 for uImage-ppc and Elf-ppc
>   Add support for reworking flat device tree support
>   Add documentation/howto for mpc85xx systems
> 
>  doc/mpc85xx.txt                       |  190 +++++++++++++++++++++
>  kexec/arch/ppc/Makefile               |    1 +
>  kexec/arch/ppc/fixup_dtb.c            |  298 ++++++++++++++++++++++++++++++++-
>  kexec/arch/ppc/fixup_dtb.h            |    6 +-
>  kexec/arch/ppc/include/arch/options.h |    3 +
>  kexec/arch/ppc/kexec-elf-ppc.c        |  186 +++++++++------------
>  kexec/arch/ppc/kexec-ppc.c            |  262 +++++++++++++++++------------
>  kexec/arch/ppc/kexec-ppc.h            |    3 +
>  kexec/arch/ppc/kexec-uImage-ppc.c     |  136 ++++++++++++---
>  kexec/arch/ppc/ops.h                  |    1 -
>  purgatory/arch/ppc/purgatory-ppc.c    |    5 +
>  11 files changed, 852 insertions(+), 239 deletions(-)
>  create mode 100644 doc/mpc85xx.txt
> 
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v3 0/7] Fixup booting with device trees and uImage/elf on ppc32

[Maxim Uvarov]

[-- Attachment #1: Type: text/plain, Size: 2500 bytes --]

2010/7/27 Simon Horman <horms@verge.net.au>

> [Cced linuxppc-dev]
>
> On Tue, Jul 20, 2010 at 11:42:57PM -0500, Matthew McClintock wrote:
> > This patch series adds full support for booting with a flat device tree
> > with either uImage or elf file formats. Kexec and Kdump should work, and
> > you should also be able to use ramdisks or reuse your current ramdisk as
> well
> >
> > This patch series was tested on an mpc85xx system with a kernel version
> > 2.6.35-rc3
> >
> > v1: Initial version
> >
> > v2: Added support for fs2dt (file system to device tree)
> >
> > v3: Fix some misc. git problems I had and other code cleanups
>
> Hi Matthew,
>
> I'm a little concerned that these changes are non trivial and haven't had
> much review. But I am prepared to put them into my tree once 2.0.2 is
> released - perhaps that way they will get some test coverage. Does
> that work for you?
>
> Actually  Matthew did that did not work before. Like kdump for booke. But
because kernel patches are not already in it's not urgent to commit it right
now.

> >
> > Matthew McClintock (7):
> >   Restore kexec uImage-ppc to working state
> >   Fix case where phys_addr_t != unsigned long when reading proc entries
> >   Update uImage to support crash kernel and misc fixes
> >   Update Elf-ppc to support crash kernel and misc fixes
> >   Add support for ramdisk on ppc32 for uImage-ppc and Elf-ppc
> >   Add support for reworking flat device tree support
> >   Add documentation/howto for mpc85xx systems
> >
> >  doc/mpc85xx.txt                       |  190 +++++++++++++++++++++
> >  kexec/arch/ppc/Makefile               |    1 +
> >  kexec/arch/ppc/fixup_dtb.c            |  298
> ++++++++++++++++++++++++++++++++-
> >  kexec/arch/ppc/fixup_dtb.h            |    6 +-
> >  kexec/arch/ppc/include/arch/options.h |    3 +
> >  kexec/arch/ppc/kexec-elf-ppc.c        |  186 +++++++++------------
> >  kexec/arch/ppc/kexec-ppc.c            |  262
> +++++++++++++++++------------
> >  kexec/arch/ppc/kexec-ppc.h            |    3 +
> >  kexec/arch/ppc/kexec-uImage-ppc.c     |  136 ++++++++++++---
> >  kexec/arch/ppc/ops.h                  |    1 -
> >  purgatory/arch/ppc/purgatory-ppc.c    |    5 +
> >  11 files changed, 852 insertions(+), 239 deletions(-)
> >  create mode 100644 doc/mpc85xx.txt
> >
> >
> >
> > _______________________________________________
> > kexec mailing list
> > kexec@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/kexec
>



-- 
Best regards,
Maxim Uvarov

[-- Attachment #2: Type: text/html, Size: 3428 bytes --]

Re: [PATCH v3 0/7] Fixup booting with device trees and uImage/elf on ppc32

[Matthew McClintock]

On Jul 26, 2010, at 9:55 PM, Simon Horman wrote:

> [Cced linuxppc-dev]
>=20
> On Tue, Jul 20, 2010 at 11:42:57PM -0500, Matthew McClintock wrote:
>> This patch series adds full support for booting with a flat device =
tree
>> with either uImage or elf file formats. Kexec and Kdump should work, =
and
>> you should also be able to use ramdisks or reuse your current ramdisk =
as well
>>=20
>> This patch series was tested on an mpc85xx system with a kernel =
version
>> 2.6.35-rc3
>>=20
>> v1: Initial version
>>=20
>> v2: Added support for fs2dt (file system to device tree)
>>=20
>> v3: Fix some misc. git problems I had and other code cleanups
>=20
> Hi Matthew,
>=20
> I'm a little concerned that these changes are non trivial and haven't =
had
> much review. But I am prepared to put them into my tree once 2.0.2 is
> released - perhaps that way they will get some test coverage. Does
> that work for you?

Either way works for me. I know they could use more review, however as =
Maxim said the current tree does not work AFAIK. Either way, I'm willing =
to keeping addressing everyones concerns and wait or move forward and =
make some quick fixes as well.

-M

>=20
>>=20
>> Matthew McClintock (7):
>>  Restore kexec uImage-ppc to working state
>>  Fix case where phys_addr_t !=3D unsigned long when reading proc =
entries
>>  Update uImage to support crash kernel and misc fixes
>>  Update Elf-ppc to support crash kernel and misc fixes
>>  Add support for ramdisk on ppc32 for uImage-ppc and Elf-ppc
>>  Add support for reworking flat device tree support
>>  Add documentation/howto for mpc85xx systems
>>=20
>> doc/mpc85xx.txt                       |  190 +++++++++++++++++++++
>> kexec/arch/ppc/Makefile               |    1 +
>> kexec/arch/ppc/fixup_dtb.c            |  298 =
++++++++++++++++++++++++++++++++-
>> kexec/arch/ppc/fixup_dtb.h            |    6 +-
>> kexec/arch/ppc/include/arch/options.h |    3 +
>> kexec/arch/ppc/kexec-elf-ppc.c        |  186 +++++++++------------
>> kexec/arch/ppc/kexec-ppc.c            |  262 =
+++++++++++++++++------------
>> kexec/arch/ppc/kexec-ppc.h            |    3 +
>> kexec/arch/ppc/kexec-uImage-ppc.c     |  136 ++++++++++++---
>> kexec/arch/ppc/ops.h                  |    1 -
>> purgatory/arch/ppc/purgatory-ppc.c    |    5 +
>> 11 files changed, 852 insertions(+), 239 deletions(-)
>> create mode 100644 doc/mpc85xx.txt
>>=20
>>=20
>>=20
>> _______________________________________________
>> kexec mailing list
>> kexec@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/kexec
>=20

Re: [PATCH v3 0/7] Fixup booting with device trees and uImage/elf on ppc32

[Simon Horman]

On Mon, Jul 26, 2010 at 11:22:58PM -0500, Matthew McClintock wrote:
> 
> On Jul 26, 2010, at 9:55 PM, Simon Horman wrote:
> 
> > [Cced linuxppc-dev]
> > 
> > On Tue, Jul 20, 2010 at 11:42:57PM -0500, Matthew McClintock wrote:
> >> This patch series adds full support for booting with a flat device tree
> >> with either uImage or elf file formats. Kexec and Kdump should work, and
> >> you should also be able to use ramdisks or reuse your current ramdisk as well
> >> 
> >> This patch series was tested on an mpc85xx system with a kernel version
> >> 2.6.35-rc3
> >> 
> >> v1: Initial version
> >> 
> >> v2: Added support for fs2dt (file system to device tree)
> >> 
> >> v3: Fix some misc. git problems I had and other code cleanups
> > 
> > Hi Matthew,
> > 
> > I'm a little concerned that these changes are non trivial and haven't had
> > much review. But I am prepared to put them into my tree once 2.0.2 is
> > released - perhaps that way they will get some test coverage. Does
> > that work for you?
> 
> Either way works for me. I know they could use more review, however as Maxim said the current tree does not work AFAIK. Either way, I'm willing to keeping addressing everyones concerns and wait or move forward and make some quick fixes as well.

All applied.

I made some minor changes to three of the patches.
I have noted each change in separate emails.