* [PATCH] Fix interrupt handling in MPC8xxx GPIO driver
@ 2011-10-11 8:24 Felix Radensky
2011-10-11 12:00 ` Greg KH
2011-11-03 17:59 ` Kumar Gala
0 siblings, 2 replies; 3+ messages in thread
From: Felix Radensky @ 2011-10-11 8:24 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Felix Radensky, stable
Interrupt handler in MPC8xxx GPIO driver is missing the call
to PIC EOI (end of interrupt) handler. As a result, at least
on 85XX systems, GPIO interrupt is delivered only once. This
patch adds the missing EOI call. Tested on custom P1022 board.
Signed-off-by: Felix Radensky <felix@embedded-sol.com>
---
arch/powerpc/sysdev/mpc8xxx_gpio.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/sysdev/mpc8xxx_gpio.c b/arch/powerpc/sysdev/mpc8xxx_gpio.c
index fb4963a..d2e0e1c 100644
--- a/arch/powerpc/sysdev/mpc8xxx_gpio.c
+++ b/arch/powerpc/sysdev/mpc8xxx_gpio.c
@@ -153,6 +153,7 @@ static void mpc8xxx_gpio_irq_cascade(unsigned int irq, struct irq_desc *desc)
if (mask)
generic_handle_irq(irq_linear_revmap(mpc8xxx_gc->irq,
32 - ffs(mask)));
+ desc->chip->eoi(irq);
}
static void mpc8xxx_irq_unmask(struct irq_data *d)
--
1.7.4.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix interrupt handling in MPC8xxx GPIO driver
2011-10-11 8:24 [PATCH] Fix interrupt handling in MPC8xxx GPIO driver Felix Radensky
@ 2011-10-11 12:00 ` Greg KH
2011-11-03 17:59 ` Kumar Gala
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2011-10-11 12:00 UTC (permalink / raw)
To: Felix Radensky; +Cc: linuxppc-dev, stable
On Tue, Oct 11, 2011 at 10:24:21AM +0200, Felix Radensky wrote:
> Interrupt handler in MPC8xxx GPIO driver is missing the call
> to PIC EOI (end of interrupt) handler. As a result, at least
> on 85XX systems, GPIO interrupt is delivered only once. This
> patch adds the missing EOI call. Tested on custom P1022 board.
>
> Signed-off-by: Felix Radensky <felix@embedded-sol.com>
> ---
> arch/powerpc/sysdev/mpc8xxx_gpio.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix interrupt handling in MPC8xxx GPIO driver
2011-10-11 8:24 [PATCH] Fix interrupt handling in MPC8xxx GPIO driver Felix Radensky
2011-10-11 12:00 ` Greg KH
@ 2011-11-03 17:59 ` Kumar Gala
1 sibling, 0 replies; 3+ messages in thread
From: Kumar Gala @ 2011-11-03 17:59 UTC (permalink / raw)
To: Felix Radensky; +Cc: linuxppc-dev list
On Oct 11, 2011, at 3:24 AM, Felix Radensky wrote:
> Interrupt handler in MPC8xxx GPIO driver is missing the call
> to PIC EOI (end of interrupt) handler. As a result, at least
> on 85XX systems, GPIO interrupt is delivered only once. This
> patch adds the missing EOI call. Tested on custom P1022 board.
>
> Signed-off-by: Felix Radensky <felix@embedded-sol.com>
> ---
> arch/powerpc/sysdev/mpc8xxx_gpio.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
applied. fixed to apply to new location of gpio driver
- k
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-03 18:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-11 8:24 [PATCH] Fix interrupt handling in MPC8xxx GPIO driver Felix Radensky
2011-10-11 12:00 ` Greg KH
2011-11-03 17:59 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox