From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
Ian Munsie <imunsie@au1.ibm.com>,
Christophe Lombard <clombard@linux.vnet.ibm.com>,
kernel-janitors@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Frederic Barrat <fbarrat@linux.vnet.ibm.com>
Subject: Re: [PATCH] cxl: Unlock on error in probe
Date: Fri, 5 May 2017 10:39:07 +0300 [thread overview]
Message-ID: <20170505073907.wtuyp3ldbsytivhu@mwanda> (raw)
In-Reply-To: <590C2856.5070905@bfs.de>
On Fri, May 05, 2017 at 09:23:02AM +0200, walter harms wrote:
> > sem is a global and it looks like it's intended to be held after
> > device_open() returns and only released in device_close(), so this looks
> > wrong.
> >
>
> the patch relates to the error path, do you expect a close() after the open() failed ?
>
You can't close if open fails. Please don't ask rhetorical questions.
Just state everything in short sentences using simple words.
regards,
dan carpenter
next prev parent reply other threads:[~2017-05-05 7:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170505053622.0670F124037@b01ledav002.gho.pok.ibm.com>
2017-05-05 7:14 ` [PATCH] cxl: Unlock on error in probe Andrew Donnellan
2017-05-05 7:23 ` walter harms
2017-05-05 7:39 ` Dan Carpenter [this message]
2017-05-05 7:37 ` Dan Carpenter
[not found] ` <20170505073800.4F753124037@b01ledav002.gho.pok.ibm.com>
2017-05-05 7:46 ` Andrew Donnellan
2017-05-05 5:34 Dan Carpenter
2017-05-05 15:29 ` Frederic Barrat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170505073907.wtuyp3ldbsytivhu@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=clombard@linux.vnet.ibm.com \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox