From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ian Munsie <imunsie@au1.ibm.com>,
Christophe Lombard <clombard@linux.vnet.ibm.com>,
kernel-janitors@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Frederic Barrat <fbarrat@linux.vnet.ibm.com>
Subject: Re: [PATCH] cxl: Unlock on error in probe
Date: Fri, 5 May 2017 17:46:05 +1000 [thread overview]
Message-ID: <c275cb27-e31c-78a8-3672-85014b9c7776@au1.ibm.com> (raw)
In-Reply-To: <20170505073800.4F753124037@b01ledav002.gho.pok.ibm.com>
On 05/05/17 17:37, Dan Carpenter wrote:
> On Fri, May 05, 2017 at 05:14:15PM +1000, Andrew Donnellan wrote:
>> sem is a global and it looks like it's intended to be held after
>> device_open() returns and only released in device_close(), so this looks
>> wrong.
>>
>
> This doesn't affect the success path, it only means that if
> device_open() fails because we don't have enough free memory or whatever
> then we can try again later.
Argh, I completely missed the "return 0" above err1 and thought the
success path fell through. My mistake, that's what I get for trying to
review patches after staring at hardware simulation logs all day...
In that case, the patch looks fine to me.
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2017-05-05 8:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170505053622.0670F124037@b01ledav002.gho.pok.ibm.com>
2017-05-05 7:14 ` [PATCH] cxl: Unlock on error in probe Andrew Donnellan
2017-05-05 7:23 ` walter harms
2017-05-05 7:39 ` Dan Carpenter
2017-05-05 7:37 ` Dan Carpenter
[not found] ` <20170505073800.4F753124037@b01ledav002.gho.pok.ibm.com>
2017-05-05 7:46 ` Andrew Donnellan [this message]
2017-05-05 5:34 Dan Carpenter
2017-05-05 15:29 ` Frederic Barrat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c275cb27-e31c-78a8-3672-85014b9c7776@au1.ibm.com \
--to=andrew.donnellan@au1.ibm.com \
--cc=clombard@linux.vnet.ibm.com \
--cc=dan.carpenter@oracle.com \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox